1585776 - Failing test browser_policy_extensionsettings.js on fission

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, defect, P3)

Description

[Mike Kaply [:mkaply]]

The test browser_policy_extensionsettings.js was marked as failing on fission.

The reason for the failure is that two of the tasks in the test click on a link to install an addon. Prior to fission, those linked to the addon XPI directly. With fission, they open a blank page so the test fails.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1585776 - Fix XPInstall content handler under Fission. r=nika

The XPInstall content handlers currently make all sorts of assumptions about
the process they're being run in and the docShell their request is tied to.
These assumptions don't hold under Fission, either now, when they may be
called just after a process switch, or in the future, when they'll be called
in the parent process.

This patch updates them to operate on the BrowsingContext of the request, and
to do their messaging via the process message manager, rather than via frame
message managers. As a bonus, it also removes the existing hacks they had in
place to handle the cases where frame message managers didn't work.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93c2588d2799
Fix XPInstall content handler under Fission. r=nika

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/93c2588d2799

Comment 5

[Alex Cornestean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!