1587711 - Firefox prevents FPN add-on from installing from new tabs/windows/private windows

Status: RESOLVED DUPLICATE of bug 1585776

(Toolkit :: Add-ons Manager, defect)

Description

[Alex Cornestean]

Attachment: Firefox prevents FPN installation.gif

[Affected versions]:
• Firefox 71.0a1 (20191007215350)
• Firefox 70.0b13 (20191007220302)
• Firefox 69.0.2 (20191001234643)

[Affected platforms]:
• Windows 10 Pro 64-bit
• MacOS High Sierra 10.13.6

[Steps to reproduce]:

1. Install a VPN and set it to United States for the extension to be available for installation from https://private-network.firefox.com
2. Navigate to https://private-network.firefox.com
3. Locate the “+ Add to Firefox” button and middle click it OR right click it and select “Open Link in New Tab” / “Open Link in New Window” / “Open Link in New Private Window”
4. Switch to the newly opened tab/window/private window
5. Notice that a door hanger is displayed stating that Firefox prevented the add-on installation

[Description]:
Firefox will prevent the installation of FPN add-on (Firefox Private Network) when using either middle click OR right click and “Open Link in New Tab” / “Open Link in New Window” / “Open Link in New Private Window” on the “+ Add to Firefox” button from https://private-network.firefox.com while also displaying a door hanger stating this prohibition. For further details, please see the attached video (the video depicts only the middle click being performed on the button, however, the same results are obtained when performing the rest of the mentioned actions, as well).

Note: Users can properly install the add-on by left clicking the above mentioned button.

[Expected results]:
The browser should allow the installation of the add-on from new tabs/windows/private windows opened via middle click or right click and “Open Link in New Tab” / “Open Link in New Window” / “Open Link in New Private Window” performed on the “+ Add to Firefox” button. Additionally, the door hanger should no longer be displayed.

[Actual results]:
The browser prohibits the installation of the add-on from new tabs/windows/private windows opened via middle click or right click and “Open Link in New Tab” / “Open Link in New Window” / “Open Link in New Private Window” performed on the “+ Add to Firefox” button while also displaying a door hanger stating this.

Comment 1

[Shane Caraveo (:mixedpuppy)]

This is intentionally prevented here:

https://searchfox.org/mozilla-central/rev/ebe492edacc75bb122a2b380e4cafcca3470864c/toolkit/mozapps/extensions/AddonManager.jsm#2336

In this case, the browser principal is a nullPrincipal so the subsumes check fails.

Looking into whether that can be loosened up.

Comment 2

[Shane Caraveo (:mixedpuppy)]

https://gist.github.com/mixedpuppy/ef4f5e1e4067390d67e61cdebeae4505

Kris, is there a reason we shouldn't do this?