1585926 - HTMLTooltip should throw when the provided document is not the toolbox document

Status: NEW

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

The HTML Tooltip expects to have access to the toolbox document. The toolbox document is a XUL document, which allows to create the XUL panel wrapper, needed to create tooltips that can expand outside of the toolbox's frame.

We should either enforce callers to pass a real toolbox document, and throw if provided with any other document. Or we should introduce a way to climb up to the toolbox document if the caller provided a subdocument.

Comment 1

[Julian Descottes [:jdescottes]]

The end goal should be to remove the _isXUL helper from the HTMLTooltip:
https://searchfox.org/mozilla-central/rev/35cc00a25c4471993fdaa5761952bd3afd4f1731/devtools/client/shared/widgets/tooltip/HTMLTooltip.js#992-994

and related code.