1523868 - Add a doorhanger options menu in console toolbar

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

See the mockup

We should add a cog button that display a doorhanger menu, that will hold the console options.

At first, it should only have the "Enable timestamp" option (and the webconsole section in the settings panel should be removed).

Comment 1

[PhoenixAbhishek]

As discussed on Slack, I would like to take this up.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Thanks a lot Phoenix, the bug is assigned to you now :)

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Unassigning as discussed on Slack

Comment 4

[Armando Ferreira]

Hi Nicolas, I would like to take this bug.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Thanks Armando, it's yours!
You can take some inspiration on the accessibility panel which has exactly the same kind of UI we want to have in the console: devtools/client/accessibility/components/AccessibilityPrefs.js

Comment 6

[Armando Ferreira]

Attachment: Bug 1523868 - Add a doorhanger options menu in console toolbar - Part 1. r=nchevobbe

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03643a08fe82
Add a doorhanger options menu in console toolbar - Part 1.

Comment 8

[Dorel Luca [:dluca]]

Backed out changeset 03643a08fe82 (bug 1523868) for Node failure in Unexpected token y in JSON at position 0. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271332845&repo=autoland&lineNumber=845

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=271332845&revision=03643a08fe828fd3303e3023e157cba78db2f810

Backout:
https://hg.mozilla.org/integration/autoland/rev/4919d1f95752be8626b55eeab03c90193fb354f6

Comment 9

[Dorel Luca [:dluca]]

Backed out changeset 7f353853da83 (bug 1588793) as requsted by the dev. CLOSED TREE

Backout:
https://hg.mozilla.org/integration/autoland/rev/c991f3b3466e8cedfcdcbd9f1a24c6d8d3c30c0b

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a58b1f879571
Add a doorhanger options menu in console toolbar - Part 1.

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a58b1f879571

Comment 12

[Chris Mills [:cmills]]

Ooop, I just noticed this one! To document this, I've overhauled the main "Opening the console" page to cover these options:

https://wiki.developer.mozilla.org/en-US/docs/Tools/Web_Console/Opening_the_Web_Console#Toolbar

Let me know if you'd like anything else here. Thanks!

Comment 13

[Nicolas Chevobbe [:nchevobbe]]

Thanks Chris, that looks good to me! (and thanks for the updated screenshots)