Closed Bug 15861 Opened 20 years ago Closed 20 years ago

Pref UI uses opposite value from 4.x: play_sound

Categories

(SeaMonkey :: MailNews: Message Display, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: laurel, Assigned: sspitzer)

Details

Using 1999-10-07-14m11 NT 4.0
This pref not applicable in 4.x on Linux
Mac sound pref different

mail.play_sound: Seamonkey appears to be using the pref
value in reverse/opposite to engage the prefs UI.  So, a value for the pref
which would cause the pref to display enabled in 4.x will cause it to display
disabled in 5.0.

This affects migration in that the migrated pref UI displays the opposite
enabled/disabled state after migration.

1.  In 4.x communicator, disable/uncheck the mail.play_sound pref.
This is accessible via Edit|Preferences|Mail and Newsgroups and is located
toward the bottom of the mail and newsgroups pref panel. Confirm OK, exit
communicator.
2.  Check the 4.x prefs.js file and notice the pref value reflecting disabled
state in 4.x: user_pref("mail.play_sound", false)
3.  Migrate that profile to seamonkey.
4.  Launch Messenger and open the prefs dialog and check the UI's state of the
pref -- it is checkmarked/enabled. This is opposite 4.x
5.  Check the seamonkey prefs.js file and notice the value for the pref is still
listed false.  Exit and relaunch doesn't shift the prefs.js or UI value in
seamonkey.
6.  Create a new profile in seamonkey and enable the pref. Double-check that the
pref indeed does stick as enabled in the UI after exit.
7.  Check the new profile's prefs.js file and notice the value for the pref is
false, which is opposite the 4.x translation for enabled.
QA Contact: lchiang → laurel
Via email, Seth mentioned that Unix will also have play_sound pref in seamonkey,
so this bug will apply to linux, too.  It won't however affect migration on Unix
since it was not a Unix pref in 4.x.

I'm not yet sure how Mac will be handled in seamonkey. Currently mac has a
different pref name and value is the type of sound user has selected for the
notification sound rather than a mere true/false value.
OS: Windows NT → All
Hardware: PC → All
Changing platform/os to all for now.  When using current seamonkey mac ui for
this pref, it enters a mail.play_sound line into prefs.js.  At this point,
migration isn't affected for mac since 4.x mac used "mail.notification.sound".
accepting bug.
Target Milestone: M12
M12
Target Milestone: M12 → M13
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
fixed.

PrefWindow now supports "reversed" on checkboxes.

I stole the "reversed" idea from alecf's account manager.
Status: RESOLVED → VERIFIED
OK using jan0 builds.  All platforms using false == disabled and true == enabled
in 5.0 UI.  Still an issue open for Mac for 4.x migration since mac used a
different pref in 4.x for sound -- that is covered in bug #15900.

A side issue is that when enabled/true, there is no line present in prefs.js.
Will track as a separate issue and log a bug if appropriate.

Marking this bug verified for 5.0 UI value usage.
OK using 2000-01-06-08 commercial NT 4.0
OK using 2000-01-06-08 mozilla linux 6.0
OK using 2000-01-06-11 commercial mac OS 8.5.1
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.