1586134 - Suboptimal focus behavior when clicking on address bar buttons

Status: NEW

(Firefox :: Address Bar, defect, P5)

Description

[Okarin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

On a new profile (with megabar enabled):

1. browse to any website (e.g. https://www.mozilla.org/en-US/)
2. click on the urlbar
3. click on the "Enhanced Tracking Protection" (shield) button
4. click on the "Site Identity" (lock) button
5. click on the "Bookmarks" (star) button
6. click on the "Pocket" button
7. click on the urlbar
8. click on the urlbar menu (· · ·)

Actual results:

2. the urlbar get the focus
3. the "Enhanced Tracking Protection" window is opened and the urlbar lose the focus
4. the "Enhanced Tracking Protection" window is close, the "Site Identity" window is opened and the urlbar get the focus again
5. the "Site Identity" window is closed, the "Bookmarks" window is opened and the urlbar loose the focus
6. the "Bookmarks" window is closed, the "Pocket" window is opened and the urlbar get the focus and loose it instantly
7. the "Pocket" window is closed and the urlbar get the focus
8. the urlbar menu is opened and the urlbar keep the focus

Expected results:

The urlbar should not gain focus when a window / menu opened from an urlbar button is still present.

Comment 1

[Dão Gottwald [:dao]]

Okarin, do you still see problems in Nightly?

Harry, do you think there's something left to do here after bug 1583535?

Comment 2

[Harry Twyford]

While bug 1583535 fixed the expansion issue, there's a bit more work to do with the focus states. Switching between panels directly, such as clicking on the ETP icon immediately followed by the identity icon unfocuses the bar for the ETP click, then refocuses the bar on the identity icon click.

We should probably suppress focus if we're in a popupshowing event. This would cover blurring the bar when panels are initially focused (which we already do) and not focusing the bar if we're switching between panels directly.

Comment 3

[Dão Gottwald [:dao]]

That doesn't seem megabar-specific though. It also feels increasingly like an edge-case, so we might want to downgrade this to P5 or just wontfix it.

Comment 4

[Harry Twyford]

Yes, that behaviour existed pre-megabar. I agree that it's a pretty low priority, but something worth fixing eventually. I think P5 is appropriate.

Comment 5

[Drew Willcoxon :adw]

When I try this now, the urlbar retains focus/selection when I click the shield and lock icons but not the bookmarks star.