1586175 - back out bug 1351924 for Firefox 70

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'd like to back out bug 1351924 for Firefox 70, because of regression bug 1584018 and the possibility of other sites being broken due to the same bug, since I think it's better not to try landing the fixes this late in the cycle. But I'd like to to this backout only on beta so that we can continue moving forwards on nightly.

I'm not entirely sure what the procedure for a backout only-on-beta is these days, given the phabricator/lando workflow we mostly use now.

I'm also going to be away and probably not around to help with this, but I'm hoping that dholbert could help if needed.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: backout patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 9098885 [details] [diff] [review]
backout patch

Beta/Release Uplift Approval Request

• User impact if declined: regressions such as bug 1584018
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): reverting to the state in the previous release
• String changes made/needed: no

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9098885 [details] [diff] [review]
backout patch

Backout, includes test changes. Let's land this on beta only for beta 13.

Comment 4

[Daniel Holbert [:dholbert]]

Thanks, Liz!

Let me know if we should land this manually.

(Last I checked, there are dedicated folks who land beta-approved patches, on a timeframe that works well for RelEng, so I'm assuming that'll happen here, but correct me if that's changed & we should take action to land it.)

Comment 5

[Daniel Holbert [:dholbert]]

We also need to backout the test that landed in bug 1576864 (which is expected to fail without bug 1351924's fix), to avoid perma-orange.

I'll post a patch to do that shortly.

Comment 6

[Daniel Holbert [:dholbert]]

Attachment: followup: also back out a test that (expectedly) becomes perma-fail

Comment 7

[Razvan Maries]

https://hg.mozilla.org/releases/mozilla-beta/rev/2a4623b24483

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Initial backout patch: https://hg.mozilla.org/releases/mozilla-beta/rev/ab40d917937e833cf869e1418ae622053d0df827