Closed Bug 1586284 Opened 5 years ago Closed 5 years ago

Implement two-line layout for results in small windows

Categories

(Firefox :: Address Bar, enhancement, P2)

Product:
Firefox
Component:
Address Bar
Type:
enhancement
Points:
5

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 72
Iteration:
72.2 - Nov 4 - 17
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mak, Assigned: mak)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Investigation comparison (70% is current)
134.50 KB, image/png
Details
Spec multi-line
513.18 KB, image/png
Details
Bug 1586284 - Modify the flex layout to give urls more space on small screens. r=dao
47 bytes, text/x-phabricator-request
Details | Review

Because the panel is smaller, urls may be cropped more aggressively. We may evaluate small changes to increase the available width for them, so that the user gains some additional browsing context.

Summary: Investigate modified the flex layout to give urls a little bit more space → Investigate modifying the flex layout to give urls a little bit more space

I'll do some investigation/experimenting.

Assignee: nobody → mak77
Status: NEW → ASSIGNED
Iteration: --- → 72.1 - Oct 21 - Nov 3

Results are not particularly conclusive, but a 5% increase doesn't seem to bring bad consequences.

Flags: needinfo?(mverdi)

Discussing with Verdi, another possibility I will investigate next week is to wrap the url to a second row, using the flexible layout.
That requires quite a few dom changes, so I will first experiment in a separate build, validate the approach with Verdi and then see where we're headed.

Flags: needinfo?(mverdi)
Iteration: 72.1 - Oct 21 - Nov 3 → 72.2 - Nov 4 - 17
Points: 2 → 5

Spoke with Verdi last week, I'm going to do some experiments with wrapping the url to a second line.

Priority: P3 → P2
Attached image Spec multi-line —

I'm currently investigating this suggestion by Verdi to move urls to a second line when the space is constrained

Summary: Investigate modifying the flex layout to give urls a little bit more space → Modifying the flex layout to give urls more space on small screens
Summary: Modifying the flex layout to give urls more space on small screens → Modify the flex layout to give urls more space on small screens

Let the url wrap, when the screen size is smaller than a threshold (maye be
tweaked in the future). Along with a new proposal by Verdi for the toolbar
overflow behavior, this should allow the urlbar to stay usable in small windows.

Because the title in Quantum Bar should never be empty, a few rules can be
simplified, so they also apply to the url when it's not a sibling of the other
result parts.

Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/b70e9a9a4486
Modify the flex layout to give urls more space on small screens. r=dao

https://hg.mozilla.org/mozilla-central/rev/b70e9a9a4486

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Regressions: 1599217
Summary: Modify the flex layout to give urls more space on small screens → Implement two-line layout for results in small windows
Regressions: 1618878
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: