1618878 - Synced tabs results disappear when the 2-lines layout is displayed

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Harry Twyford]

Attachment: syncedtabs_2lines.mov

[screencast attached]

STR:

1. Enter a query in the Urlbar that would cause synced tab results to appear. Just searching the open tabs restriction character, "%", is probably easiest.
2. Shrink the window horizontally until you pass the threshold where 2-line results would appear in the Urlbar.

Expected:
All the same results appear in the Urlbar.

Actual:
All the synced tab results disappear. They reappear when the window is expanded.

Comment 1

[Harry Twyford]

Attachment: Bug 1618878 - Show remotetab results in the 2-lines layout. r?dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8a85168e24e
Show remotetab results in the 2-lines layout. r=dao

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d8a85168e24e

Comment 4

[Harry Twyford]

Comment on attachment 9129789 [details]
Bug 1618878 - Show remotetab results in the 2-lines layout. r?dao

Beta/Release Uplift Approval Request

• User impact if declined: Synced tab results will not appear in the address bar dropdown when the Urlbar design update is enabled.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS-only fix.
• String changes made/needed:

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9129789 [details]
Bug 1618878 - Show remotetab results in the 2-lines layout. r?dao

Needed for the pref-flip experiment in 74, taking in beta before RC.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/66a7ed7dfa65