1586306 - Modal password change dialog is shown after password generation on local files

Status: NEW

(Toolkit :: Password Manager, defect, P3)

Description

[Adrian Florinescu [:aflorinescu] [PTO until Aug 26]]]

Attachment: door-hang+modal.jpg

[Environment:]

Windows 10, Ubuntu 16.04, Mac 10.14.6
70.0b12 20191002212950
71.0a1 20191003214801

[Description:]

In bug 1564528, the modal window displaying the username drop-down for update selection in case of multiple logins for the same principal was removed in case of password generation and replaced with the door-hanger. When verifying it, we didn't cover the case in which you use file:///.

[Steps:]

1. Save https://bugs.mattn.ca/pwmgr/login_and_change_form.html as a local file.
2. Open Firefox with a new profile.
3. Load the local file saved at step 1
4. Create using "Registration form:" a bogus entry. (redirected to success.html)
5. Press back to load again the form.
6. Use the "Password change form:" to generate a new password and press "Change Password".

[Actual Result:]

Door-hanger and modal window is displayed. (see attached screenshot)
https://pastebin.com/eGx1KAdv

[Expected Result:]

Only the door-hanger should be displayed in this case.

[Note:]

Not adding the [skyline] whiteboard, since this is a minor issue only when using local files, hence given the Fx70 deadline, doubt it should be uplifted.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Thanks. Pretty low priority but marking as P3 as I think we want to get rid of that modal entirely so we might want to do this sooner than otherwise.