Closed Bug 1564528 Opened 3 months ago Closed 3 months ago

Don't show the modal password change dialog after password generation

Categories

(Toolkit :: Password Manager, enhancement, P1)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
mozilla70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- disabled
firefox70 --- verified

People

(Reporter: MattN, Assigned: ntim)

References

(Depends on 1 open bug)

Details

(Whiteboard: [passwords:generation] [skyline])

Attachments

(1 file)

Sometimes we show a modal password change dialog (see bug 1154763) but in the case of a generated password being filled, we want to show the doorhanger instead. One reason for this is because the user may want to save this generated password as a 3rd login but the current UX forces them to cause an update to one of their existing logins.

We are basically fixing bug 1154763 but only in the password generation case in order to reduce scope for Firefox 70.

We already track the GUID of a filled login so we can similarly track if a field was filled with a generated login.

Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d0e7b6c6b236
Stop showing the modal password change dialog after password generation. r=MattN
Whiteboard: [passwords:generation] [skyline]
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Using a unedited generated password, the modal is not shown. But when using an edited generated password, I still get the modal, uncertain if it is expected or not.
*edit: Guess it makes sense to treat an edited generated password as the general password case, I'm more uncertain about the cases in which we show the modal: is there a long term plan to move towards the doorhanger and drop the modal entirely?

Flags: needinfo?(MattN+bmo)

(In reply to Adrian Florinescu [:adrian_sv] from comment #6)

Using a unedited generated password, the modal is not shown. But when using an edited generated password, I still get the modal, uncertain if it is expected or not.

This should be fixed now that bug 1548861 landed but please confirm.

is there a long term plan to move towards the doorhanger and drop the modal entirely?

Yes, that is bug 1154763 in the See Also and mentioned in comment 0.

Flags: needinfo?(MattN+bmo)

Yup, cannot get the modal anymore using the same steps as in comment 6 on the latest Nightly which contains the bug 1548861. I'm marking this as verified:

tested and verified on:

    Windows 10, Ubuntu 16.04
    70.0a1 2019-08-07
Depends on: 1586306
You need to log in before you can comment on or make changes to this bug.