1586861 - SearchOneOffs.__rebuild is getting stale layout information

Status: RESOLVED FIXED

(Firefox :: Search, defect, P3)

Description

[Harry Twyford]

Currently, we use DOMUtils.getBoundsWithoutFlushing to determine if the width of the searchbar has changed and thus needs to be rebuilt. As outlined in bug 1584336 comment 12, there are two width-based layout bugs in the searchbar when it moves between the Overflow menu and the toolbar. They both have the same root cause, which is that DOMUtils.getBoundsWithoutFlushing is returning stale information and thus the searchbar popup uses old layout information.

I propose we use window.promiseDocumentFlushed to get the searchbar width instead.

Comment 1

[Harry Twyford]

Attachment: Bug 1586861 - Use promiseDocumentFlushed in SearchOneOffs.__rebuild. r?dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/030df8fe65c7
Use promiseDocumentFlushed in SearchOneOffs.__rebuild. r=dao

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 030df8fe65c7 (Bug 1586861) for causing browser-chrome failures

Range of failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=0b4ef9402dd4b9a9d619e8d3b96d7696465f4aaa&fromchange=030df8fe65c7346ab9a57e804dd4cd26a85b7c57&tochange=033f7df325fe71d79a8ef5664df5b0801371c955

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270353445&repo=autoland&lineNumber=14659

Backout: https://hg.mozilla.org/integration/autoland/rev/033f7df325fe71d79a8ef5664df5b0801371c955

Comment 4

[Harry Twyford]

Clearing ni since there’s a new revision on Phabricator for review.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3297a09b231a
Use promiseDocumentFlushed in SearchOneOffs.__rebuild. r=dao

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3297a09b231a