SearchOneOffs.__rebuild is getting stale layout information
Categories
(Firefox :: Search, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(1 file)
Currently, we use DOMUtils.getBoundsWithoutFlushing to determine if the width of the searchbar has changed and thus needs to be rebuilt. As outlined in bug 1584336 comment 12, there are two width-based layout bugs in the searchbar when it moves between the Overflow menu and the toolbar. They both have the same root cause, which is that DOMUtils.getBoundsWithoutFlushing is returning stale information and thus the searchbar popup uses old layout information.
I propose we use window.promiseDocumentFlushed to get the searchbar width instead.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/030df8fe65c7 Use promiseDocumentFlushed in SearchOneOffs.__rebuild. r=dao
|
||
Comment 3•5 years ago
|
||
Backed out changeset 030df8fe65c7 (Bug 1586861) for causing browser-chrome failures
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270353445&repo=autoland&lineNumber=14659
Backout: https://hg.mozilla.org/integration/autoland/rev/033f7df325fe71d79a8ef5664df5b0801371c955
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•5 years ago
|
||
Clearing ni since there’s a new revision on Phabricator for review.
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3297a09b231a Use promiseDocumentFlushed in SearchOneOffs.__rebuild. r=dao
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•