1587259 - Improve JS address book performance

Status: RESOLVED FIXED

(MailNews Core :: Address Book, enhancement)

Description

[Geoff Lankow (:darktrojan)]

Rather than re-opening bug 1581765 to address the poor performance, I'll do it in this new bug.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1587259-jsaddrbook-perf-1.diff

This does all of the migration database writing in one go. This required turning some of the start-up functions to async functions, but I don't see any problem doing that.

I've also added two indices to the database to improve performance of the UI on large address books.

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 9099758 [details] [diff] [review]
1587259-jsaddrbook-perf-1.diff

Windows doesn't like this one either.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1587259-jsaddrbook-perf-2.diff

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9099785 [details] [diff] [review]
1587259-jsaddrbook-perf-2.diff

Review of attachment 9099785 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mkmelin

Comment 6

[:aceman]

Comment on attachment 9099785 [details] [diff] [review]
1587259-jsaddrbook-perf-2.diff

Review of attachment 9099785 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this makes the conversion much more bearable (like 1 minute for 16000 contacts) but the opening of that AB is quite fast, in seconds.
The indexes seem to double the size of the sqlite file. So when the conversion was from 6MB to 12MB, now it is 24MB (quite OK for the benefit of getting a format that can be read also outside of TB with sqlite tools).

There are still the "uncaught exceptions" remaining which make using the AB window choppy.

Comment 7

[:aceman]

What about AB files that are already converted without those indexes? How do we fix those?

Comment 8

[Geoff Lankow (:darktrojan)]

Those files will automatically be upgraded from schema version 1 to 2 when first used.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0e8585d9cfce
Improve JS address book performance. r=mkmelin