Closed Bug 1597394 Opened 5 years ago Closed 5 years ago

Address book is freezing

Categories

(Thunderbird :: Address Book, defect)

Product:
Thunderbird
Component:
Address Book
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: stepand76, Unassigned)

References

Details

(Keywords: perf)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

  1. Start TB 71b3 (without add-ons) on Windows 10.
  2. Open Address Book.
  3. Double click a contact.
  4. Click OK.

Actual results:

Address Book and TB freezes. TB use lot of CPU time.

Expected results:

It think it is clear what is expected here :-)

Keywords: perf

Works fine here. I'm going to need more info.

Did you just update from beta 2? Did it work okay in 71 b2? Does it happen with a new profile? Is there anything unusual about your address book, like being especially large?

(In reply to Geoff Lankow (:darktrojan) from comment #1)

Works fine here. I'm going to need more info.
Did you just update from beta 2?

Yes.

Did it work okay in 71 b2?

No. On my computer in office there is still beta 2 and I can reproduce it here.

Does it happen with a new profile?

I don't know yet. I will let you know.

Is there anything unusual about your address book, like being especially large?

I use gContactSync add-on. Maybe it extends the contact fields which can results to problems with new AB format. But I have tried to disable this add-on, it doesn't help.

I have about 1200 contacts in my address book. My abook.sqlite file size is 4,4 MB.

(In reply to Geoff Lankow (:darktrojan) from comment #1)

Works fine here. I'm going to need more info.
Does it happen with a new profile?

No. When I put my abook.sqlite file to new profile then it happens.
What can be wrong with the file?

Severity: normal → critical
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(geoff)

"Ivan" has posted a performance issue at https://discourse.mozilla.org/t/thunderbird-beta-not-responding-and-freezes-on-windows-caused-by-windows-defender/32533/22? but it is unclear that it matches the issue of this bug report.

Blocks: 1587259

Is there some workaround? Or is the only way to rollback to stable channel version? I need to edit contacts...

It looks like safe mode is yet to be tested. Please Start Windows' safe mode with networking enabled

Still In Windows safe mode, start thunderbird in safe mode

Does problem go away?

Flags: needinfo?(stepand76)

(In reply to stepand76 from comment #0)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

  1. Start TB 71b3 (without add-ons) on Windows 10.
  2. Open Address Book.
  3. Double click a contact.
  4. Click OK.

Actual results:

Address Book and TB freezes. TB use lot of CPU time.

Expected results:

It think it is clear what is expected here :-)

I can confirm this albeit a different way. My STR are to 1) compose a new email, 2) start typing in the To: field a contact you know is in your address book. There is a pause / freeze before it appears. I have seen this since moving to 71.0b. 70.0b didn't have this issue. It's a bit better since moving to 71.0b3. On my home PC (Win 10 1909 x64, 16GB RAM, 256MB Samsung 850 Pro SSD, i7 3770, x64 Thunderbird), it takes about 2 seconds before a contact appears. On my less capable work machine, there's a 4-5 second pause before a contact appears. In TB 70.0b x64 and before, it used to appearalmost instantaneous and without any freeze / pause.

(In reply to Wayne Mery (:wsmwk) from comment #6)

It looks like safe mode is yet to be tested. Please Start Windows' safe mode with networking enabled

Still In Windows safe mode, start thunderbird in safe mode

Does problem go away?

I tested Safe Mode and it's still there.

(In reply to Wayne Mery (:wsmwk) from comment #6)

It looks like safe mode is yet to be tested. Please Start Windows' safe mode with networking enabled

Still In Windows safe mode, start thunderbird in safe mode

Does problem go away?

No, it doesn't.

Flags: needinfo?(stepand76)

In the latest nightly build I've landed a patch which potentially fixes this problem. Please try that, with a fresh profile and your address book.

Flags: needinfo?(geoff)

Tried the nightly build. It was the same.
I also tried to export my contact list to a CSV file and import it to empty contact list. After that it works in the nightly!

Well that's weird. I wonder if your database is stuck at version 1 and never got the upgrades I added in bug 1587259.

I'd like to see the output of running SELECT * FROM sqlite_master; on abook.sqlite if that's possible. (I've no recommendations for an SQLite tool on Windows, unfortunately.)

(In reply to Geoff Lankow (:darktrojan) from comment #12)

Well that's weird. I wonder if your database is stuck at version 1 and never got the upgrades I added in bug 1587259.

I'd like to see the output of running SELECT * FROM sqlite_master; on abook.sqlite if that's possible. (I've no recommendations for an SQLite tool on Windows, unfortunately.)

I just tried using a free tool called SQLiteStudio 3.2.1 Portable along with your above statement saved as an SQL script via Notepad++ and the SQLinForm plugin for Notepad++ but wasn't able to see any useful output. Maybe someone smarter than me can figure it out.

Maybe https://sqlite.org/2019/sqlite-tools-win32-x86-3300100.zip might be of use? "A bundle of command-line tools for managing SQLite database files, including the command-line shell program, the sqldiff.exe program, and the sqlite3_analyzer.exe program."

Not sure if it is you are asking for:

table|cards|cards|2|CREATE TABLE cards (uid TEXT PRIMARY KEY, localId INTEGER)
index|sqlite_autoindex_cards_1|cards|3|
table|properties|properties|4|CREATE TABLE properties (card TEXT, name TEXT, value TEXT)
table|lists|lists|5|CREATE TABLE lists (uid TEXT PRIMARY KEY, localId INTEGER, name TEXT, nickName TEXT, description TEXT)
index|sqlite_autoindex_lists_1|lists|6|
table|list_cards|list_cards|7|CREATE TABLE list_cards (list TEXT, card TEXT, PRIMARY KEY(list, card))
index|sqlite_autoindex_list_cards_1|list_cards|8|
index|properties_card|properties|9|CREATE INDEX properties_card ON properties(card)
index|properties_name|properties|10|CREATE INDEX properties_name ON properties(name)

(In reply to Arthur K. from comment #13)

(In reply to Geoff Lankow (:darktrojan) from comment #12)

Well that's weird. I wonder if your database is stuck at version 1 and never got the upgrades I added in bug 1587259.

Is there a way to force the upgrade?

Just wanted to report that after bumping up to 72.0b1 x64, this is MUCH improved now. On my work laptop, it appears within 1/4 second now.

(In reply to Arthur K. from comment #17)

Just wanted to report that after bumping up to 72.0b1 x64, this is MUCH improved now. On my work laptop, it appears within 1/4 second now.

Where I can get it?

(In reply to stepand76 from comment #18)

(In reply to Arthur K. from comment #17)

Just wanted to report that after bumping up to 72.0b1 x64, this is MUCH improved now. On my work laptop, it appears within 1/4 second now.

Where I can get it?

From where did you get 71.0b3?

Via automatic update. It doesn't offer update to 72b1.

(In reply to stepand76 from comment #20)

Via automatic update. It doesn't offer update to 72b1.

I think once it hits the TB beta site you'll likely get notification of the update. My hunch is that will be by the end of the week or early next week.

I assume that Arthur is getting pre-release builds of 72 beta from our build infrastructure or building his own, as we've not built and released it yet. Any significant changes affecting this bug are in 71 beta 4 which was released at the end of last week.

Also, now that I'm here commenting I realise I never responded to comment 15 or comment 16. Sorry.

(In reply to stepand76 from comment #15)

Not sure if it is you are asking for:

It's exactly what I was asking for, and exactly as expected, so my theory about that was no good.

(In reply to Arthur K. from comment #16)

Is there a way to force the upgrade?

This isn't a problem, the code is working as expected.

(In reply to Geoff Lankow (:darktrojan) from comment #22)

Any significant changes affecting this bug are in 71 beta 4 which was released at the end of last week.

In 71.0b4 it works me when I:

  1. Export my contacts to CSV.
  2. Delete manually all address book files from my profile.
  3. Import contacts back. Noticed that some contacts imported without name and display name (they had just Company name previously). Not sure if it can cause the issue.
    After steps above AB stopped freezing.

Based on comment 23, is this an actionable issue?

Flags: needinfo?(geoff)
See Also: → 1590237

Only if I can get my hands on an address book displaying the problem.

@stepand76: if you're willing to share your broken abook.sqlite with only me, email me directly.

Flags: needinfo?(geoff) → needinfo?(stepand76)

(In reply to Wayne Mery (:wsmwk) from comment #24)

Based on comment 23, is this an actionable issue?

For me it is resolved issue.

Flags: needinfo?(stepand76)

Thanks for the update(s).

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.