1587329 - Add more assertions where CorePS::sInstance or ActivePS::sInstance are used

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

There have been some strange crashes, and to eliminate a source of troubles I would like to add more assertions where CorePS::sInstance or ActivePS::sInstance are used.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1587329 - MOZ_ASSERT(sInstance) in all functions that dereference sInstance - r?canaltinova

Add assertions that all sInstance pointers (from both CorePS and ActivePS)
are not null before being dereferenced.

This is probably more than needed, but it's only MOZ_ASSERTs limited to
Nightly, and it should give better feedback in case something goes wrong.

Eventually, I think it would be better to make most methods non-static, and have
a checked reference-to-instance getter.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Will wait until bug 1512500 lands, as it may affect this patch...

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cba15804370
MOZ_ASSERT(sInstance) in all functions that dereference sInstance - r=canaltinova

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0cba15804370