1587496 - Update nsIBrowserHandler users in browser.js to use new BrowserHandler lazy getter

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P5)

Description

[Mike Kaply [:mkaply]]

In bug 158968, a getter was added to use nsIBrowserHandler as BrowserHandler.

We should update the two places that still get the service to use the getter:

https://searchfox.org/mozilla-central/search?q=Ci.nsIBrowserHandler&case=false&regexp=false&path=browser.js

Comment 1

[squidney]

This seems pretty simple. Can i have this bug?

Comment 2

[Mike Kaply [:mkaply]]

Sure. I'll assign it to you once a patch is up.

This page should help.

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

Comment 3

[squidney]

Attachment: UpdatesTo_browser/base/content/browser.js.png

Our team updated the two places that still get the service to use the getter. Here is our patch for review. And here is a link to the updated file on our GitHub
https://github.com/CSCI-462-02-2020/Sleep-Deprived/blob/master/browser.js

Comment 4

[jcadler]

Hey squidney, after talking with someone on the Mozilla chat, I think the fix is actually simpler than that.

This change should work. I've simply changed the first place to:
let defaultArgs = BrowserHandler.defaultArgs;

and the second place to:
var handler = BrowserHandler;

The patch is attached.

/Users/jasonadler/Desktop/browser.js

https://github.com/adlerjasonc/firefox/blob/master/browser.js

Comment 5

[Mike Kaply [:mkaply]]

Thanks for this. If you look at the top of the file,

https://github.com/adlerjasonc/firefox/blob/master/browser.js#L253

there's a place to globally define the lazy service getter.

Then you would use that getter to access the appropriate parameters of the browser handler.

Comment 6

[Mike Kaply [:mkaply]]

Also, please take a look at using phabricator to submit patches:

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

Comment 7

[squidney]

Attachment: Bug 1587496 - 1587496: Updated nsIBroswerHandler in browser.js users to use new BrowserHandler lazy getter r=mkaply

Comment 8

[squidney]

Attachment: Bug 1587496: - 1587496: Updated nsIBroswerHandler in browser.js users to use new BrowserHandler lazy getter

Comment 9

[squidney]

Attachment: Bug 1587496 - Update nsIBrowserHandler users in browser.js to use new BrowserHandler lazy getter. r=mkaply

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fcfa5bc49e5
Update nsIBrowserHandler users in browser.js to use new BrowserHandler lazy getter. r=mkaply

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2fcfa5bc49e5