Closed Bug 1587570 Opened 1 year ago Closed 1 year ago

Remove support for the subscriptshift and superscriptshift attributes

Categories

(Core :: MathML, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: fredw, Assigned: fredw)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(2 files)

Discussion happens here but it is currently blocked on collecting statistics to determine how important they are: https://github.com/mathml-refresh/mathml/issues/27

So we can introduce a runtime flag / counter to help with that.

Attachment #9099986 - Flags: data-review?(bmiroglio)
Keywords: site-compat
Blocks: mathml-core
No longer blocks: 1548530
Comment on attachment 9099986 [details]
data-collection-mathml-script-shift-attributes.txt

# Data Review Form 

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way? 

This will be documented in the [probe dictionary](https://telemetry.mozilla.org/probe-dictionary/).

2) Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, users can toggled this off by disabling Telemetry in the Firefox Preferences.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

:fredw will monitor this data, however collection is only proposed for 6 months initially.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1: Technical Data

5) Is the data collection request for default-on or default-off?

default-on

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice? **If unsure: escalate to legal if:**

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No.

9) Does the data collection use a third-party collection tool? **If yes, escalate to legal.**

No.

data-review: r+
Attachment #9099986 - Flags: data-review?(bmiroglio) → data-review+
Attachment #9100013 - Attachment description: Bug 1587570 - Remove support for the subscriptshift and superscriptshift attributes → Bug 1587570 - Remove support for the subscriptshift and superscriptshift attributes. r=emilio
Keywords: checkin-needed

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/972db326c375
Remove support for the subscriptshift and superscriptshift attributes. r=emilio

Keywords: checkin-needed
Depends on: 1585419

I forgot to force this flag to be enabled in WPT and update expectation for mathml/presentation-markup/scripts/subsup-legacy-scriptshift-attributes-001.tentative.html ; will do that later

(In reply to Cosmin Sabou [:CosminS] from comment #7)

Sorry Frédéric I already backed it out. A heads up on the #sheriffs or #developers channel on IRC/slack would have helped.

No worries, I'll upload a new patch. Test only landed in bug 1585419, so issue didn't show up when I pushed to try. I'm currently at the web engines hackfest, so I have a lot of meetings and discussions with people and didn't have time to ping you sorry.

Flags: needinfo?(fred.wang)

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe2312ad6c4f
Remove support for the subscriptshift and superscriptshift attributes. r=emilio

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.