1587570 - Remove support for the subscriptshift and superscriptshift attributes

Status: RESOLVED FIXED

(Core :: MathML, task)

Description

[Frédéric Wang (:fredw)]

Discussion happens here but it is currently blocked on collecting statistics to determine how important they are: https://github.com/mathml-refresh/mathml/issues/27

So we can introduce a runtime flag / counter to help with that.

Comment 1

[Frédéric Wang (:fredw)]

Attachment: data-collection-mathml-script-shift-attributes.txt

Comment 2

[Frédéric Wang (:fredw)]

Attachment: Bug 1587570 - Remove support for the subscriptshift and superscriptshift attributes. r=emilio

WIP

Comment 3

[Ben Miroglio [:bmiroglio]]

Comment on attachment 9099986 [details]
data-collection-mathml-script-shift-attributes.txt

# Data Review Form 

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way? 

This will be documented in the [probe dictionary](https://telemetry.mozilla.org/probe-dictionary/).

2) Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, users can toggled this off by disabling Telemetry in the Firefox Preferences.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

:fredw will monitor this data, however collection is only proposed for 6 months initially.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1: Technical Data

5) Is the data collection request for default-on or default-off?

default-on

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice? **If unsure: escalate to legal if:**

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No.

9) Does the data collection use a third-party collection tool? **If yes, escalate to legal.**

No.

data-review: r+

Comment 4

[Frédéric Wang (:fredw)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c69cc72cadd928a6920a57dac6bbc1bd98a1e616

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/972db326c375
Remove support for the subscriptshift and superscriptshift attributes. r=emilio

Comment 6

[Frédéric Wang (:fredw)]

I forgot to force this flag to be enabled in WPT and update expectation for mathml/presentation-markup/scripts/subsup-legacy-scriptshift-attributes-001.tentative.html ; will do that later

Comment 7

[Cosmin Sabou [:CosminS]]

Sorry Frédéric I already backed it out. A heads up on the #sheriffs or #developers channel on IRC/slack would have helped.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=972db326c3754792b29dfa649d7dc18950431421&searchStr=wr&selectedJob=271484365

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=271479894&repo=autoland&lineNumber=8273

Backout link: https://hg.mozilla.org/integration/autoland/rev/5808d51ab6cba029cb5aef64762cf395180f3123

Comment 8

[Frédéric Wang (:fredw)]

(In reply to Cosmin Sabou [:CosminS] from comment #7)

Sorry Frédéric I already backed it out. A heads up on the #sheriffs or #developers channel on IRC/slack would have helped.

No worries, I'll upload a new patch. Test only landed in bug 1585419, so issue didn't show up when I pushed to try. I'm currently at the web engines hackfest, so I have a lot of meetings and discussions with people and didn't have time to ping you sorry.

Comment 9

[Frédéric Wang (:fredw)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=af80758f605ae63a72cea2b2f603d0be1c94ba5d

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe2312ad6c4f
Remove support for the subscriptshift and superscriptshift attributes. r=emilio

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/fe2312ad6c4f

Comment 12

[Kohei Yoshino [:kohei]]

Updated the site compatibility note.

Comment 13

[Florian Scholz (Open Web Docs)]

Updated:
https://developer.mozilla.org/en-US/docs/Web/MathML/Attribute
https://developer.mozilla.org/en-US/docs/Web/MathML/Element/mmultiscripts
https://developer.mozilla.org/en-US/docs/Web/MathML/Element/msub
https://developer.mozilla.org/en-US/docs/Web/MathML/Element/msup
https://developer.mozilla.org/en-US/docs/Web/MathML/Element/msubsup

Please add 'dev-doc-needed' to the bug that removes this in a stable Firefox version.