1587587 - Users can create mailing lists that won't work

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Paul Morris [:pmorris]]

See comment 18 on bug 1584211, and also these bugs:
Bug 170823: Multiple Spaces
Bug 1175900: Comma(s)
Bug [NONE?]: Semicolon(s)
Bug 1156245: Multiple Double Quotes

Ultimately, it might be nice to allow mailing list names with these characters, but we do users no favors by letting them create mailing lists that don't work. So I think it's worth going ahead and fixing this by showing an error dialog that alerts users to the problem and lets them fix it when they are naming a mailing list. If we like we can re-visit after the changes in bug 440377 are in place.

Comment 1

[Paul Morris [:pmorris]]

Attachment: no-more-broken-mailing-lists-0.patch

Alerts the user if they try to create or edit a mailing list name with characters that will make it fail when composing a message to the list.

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 9099999 [details] [diff] [review]
no-more-broken-mailing-lists-0.patch

Review of attachment 9099999 [details] [diff] [review]:
-----------------------------------------------------------------

I don't like this wording. Windows says this when you make use an illegal character: "A filename can't contain any of the following characters: \ / : * etc.", so maybe something like it.

If you had a separate message for adjacent spaces (which I think you should do anyway), you could replace the awkward regexp with `for (let c of ';,"<>') …`.

Comment 3

[Paul Morris [:pmorris]]

Attachment: no-more-broken-mailing-lists-1.patch

Good call, I like this better too.

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9100304 [details] [diff] [review]
no-more-broken-mailing-lists-1.patch

Review of attachment 9100304 [details] [diff] [review]:
-----------------------------------------------------------------

Better!

Comment 5

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/7e9ef7f6158ab14df2c9c439882ff91b0aa2fe47
Show an alert if a new mailing list name won't work. r=darktrojan

Comment 6

[Jorg K (CEST = GMT+2)]

TB 70 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/2ecd5527f4bd2043d89e37010bd5ab952cc00e60

Oops, this shouldn't have gone to beta since it had string changes.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9100304 [details] [diff] [review]
no-more-broken-mailing-lists-1.patch

Can't do ESR 68 here due to the strings.