Closed Bug 1587673 Opened 5 years ago Closed 5 years ago

glodaList tab mode should be considered a mailTab for WebExtensions

Categories

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Product:
Thunderbird
Component:
Add-Ons: Extensions API
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr6870+ fixed, thunderbird70 fixed, thunderbird71 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 71.0
Tracking Flags:
Tracking Status
thunderbird_esr68 70+ fixed
thunderbird70 --- fixed
thunderbird71 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(1 file)

1587673-glodalist-tab-1.diff
10.19 KB, patch
mkmelin
: review+
jorgk-bmo
: approval-comm-beta+
jorgk-bmo
: approval-comm-esr68+
Details | Diff | Splinter Review

This tab mode is very similar to the folder mode, in fact I didn't realise it was a separate mode. The mailTab APIs should be able to see it and do (almost) everything that can be done with folder tabs.

Note to self: this also includes the messageDisplay API.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9100083 - Flags: review?(mkmelin+mozilla)
Attachment #9100083 - Flags: approval-comm-esr68?
Attachment #9100083 - Flags: approval-comm-beta?
Comment on attachment 9100083 [details] [diff] [review] 1587673-glodalist-tab-1.diff Review of attachment 9100083 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Attachment #9100083 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
Attachment #9100083 - Flags: approval-comm-beta? → approval-comm-beta+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/50a318e63c95
glodaList tab mode should be considered a mailTab for WebExtensions. r=mkmelin DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
Comment on attachment 9100083 [details] [diff] [review] 1587673-glodalist-tab-1.diff Let's assume this isn't causing trouble on beta.
Attachment #9100083 - Flags: approval-comm-esr68? → approval-comm-esr68+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: