1587705 - The “CFR Recommendation” button is not displayed in the minimized form after navigating to another website on the same tab

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: CFR_Minimized.mp4

[Affected versions]:

• Firefox Beta 70.0b13 build (Build ID: 20191007220302) (64-bit)
• Nightly 71.0a1 build (Build ID: 20191009213914) (64-bit)

[Affected Platforms]:

• Windows 10 x64
• Mac 10.14
• Ubuntu 16.04 x64.

[Prerequisites]:

• You are not signed in to sync.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to a login page of a website for which you don’t have the credentials saved (eg: https://twitter.com/login).
3. Complete the username and password fields with valid credentials and click the “Login” button.
4. Click the "Save" button from the "Save password" doorhanger.
5. Navigate to another website on the same tab and observe "CRF Recommendation" button from the right part of the “Address Bar”.

[Expected result]:

• The "CRF Recommendation" button is minimized.

[Actual result]:

• The "CRF Recommendation" button is still displayed in the maximized form..

[Notes]:

• Attached a screen recording with the issue.

Comment 1

[Andrei Oprea [:andreio]]

Using mozregression I tracked this down to bug 1513337. It looks like the focus event listener is added but it never fires when clicking the awesomebar.

:ntim did something change in that bug that you might think triggers this?

Comment 2

[Tim Nguyen :ntim]

Redirecting to dao who worked on bug 1513337 and knows more on the urlbar than I do :)

Comment 3

[Andrei Oprea [:andreio]]

Attachment: Bug 1587705 - The CFR Recommendation button is not displayed in the minimized form on urlbar focus

Comment 4

[Andrei Oprea [:andreio]]

Comment on attachment 9100238 [details]
Bug 1587705 - The CFR Recommendation button is not displayed in the minimized form on urlbar focus

Beta/Release Uplift Approval Request

• User impact if declined: Regression in the CFR message UI
  The message does not collapse/minimize and remains in its expanded state until dismissed by the user
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a regression that was discovered very late but the patch itself is small and there is no risk to taking it.
• String changes made/needed:

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9daa83397ca7
The CFR Recommendation button is not displayed in the minimized form on urlbar focus r=k88hudson

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9daa83397ca7

Comment 7

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20191011093010) on Windows 10 x64, Mac 10.14, Ubuntu 16 x64.

• The “CFR Recommendation” button is correctly displayed in the minimized form after navigating to another website on the same tab

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Seems fairly edge case to me, I think this can wait for 71. If you strongly disagree and think the user impact is major, you can let me know.

Comment 9

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5356