Add "format" and "quality" arguments to Page.captureScreenshot
Categories
(Remote Protocol :: CDP, enhancement, P1)
Tracking
(firefox72 fixed)
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
()
Details
(Whiteboard: [puppeteer-alpha])
Attachments
(3 files)
To be able to set the format and quality of compression (jpeg only) we have to get both arguments implemented.
|
Assignee | |
Comment 1•5 years ago
|
||
Running the puppeteer examples for screenshots I noticed that Puppeteer always sets the format argument. Currently we are raising an not yet implemented error. The implementation shouldn't be too hard, so I will have a look at it soon.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
The actual screenshot data should be returned via the "data"
property of an object. Also the data URL prefix has to be
stripped off, so that only the base64 encoded data will be
transmitted.
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D52144
|
|
Assignee | |
Comment 5•5 years ago
|
||
Depends on D52145
|
|
Assignee | |
Comment 6•5 years ago
|
||
New try build with review comments addressed:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cdd0b0c8aa1ab3074de7ac6de8a274fe02426c29
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e8155e813e54 [remote] Fix payload of return value for Page.captureScreenshot. r=remote-protocol-reviewers,ato https://hg.mozilla.org/integration/autoland/rev/cfee639c527a [remote] Add "format" option to Page.captureScreenshot. r=remote-protocol-reviewers,ato https://hg.mozilla.org/integration/autoland/rev/3ef1ca5d2649 [remote] Add "quality" option to Page.captureScreenshot. r=remote-protocol-reviewers,ato,maja_zf
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e8155e813e54
https://hg.mozilla.org/mozilla-central/rev/cfee639c527a
https://hg.mozilla.org/mozilla-central/rev/3ef1ca5d2649
|
||
Updated•3 years ago
|
Description
•