1587903 - Unable to change my Firefox add-on settings on Wayland

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P3)

Description

[raklodder]

Attachment: no user mouse/keyboard interaction

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

1. open a new firefox/wayland session.
2. left-click with your mouse to change your settings.
3. try toggling on/off everything.

Actual results:

Mouse and keyboard input doesn't register and nothing happens.

Expected results:

Ability to change my settings, toggle everything on/off like I'm used to on x11.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Can you please try latest nightly? How-to is here:
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems?rd=Bug_info_Firefox#Testing_Mozilla_binaries

Thanks.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

btw. Which Fedora version do you run?

Comment 4

[raklodder]

I did what you asked and it worked. Tested with 71.0a1 (2019-10-10) 64-bit nightly on Fedora 31 on GNOME/Wayland.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

(In reply to itrymybest80 from comment #4)

I did what you asked and it worked. Tested with 71.0a1 (2019-10-10) 64-bit nightly on Fedora 31 on GNOME/Wayland.

Good to hear!
Can you also try Firefox Beta from https://www.mozilla.org/en-US/firefox/channel/desktop/ ?
It's upcomming Firefox 70.
Thanks.

Comment 6

[raklodder]

I'm confused, tried the latest beta (firefox-70.0b13) and stable (firefox-69.0.3) and apparently they work too?

How do I know it's running on Wayland or is that built in by default, because I'm thinking it's on X11?

All I did was to download the latest beta and stable packages, extracted both, run the executables and installed my add-ons.

I tried with all of them separately on (and all turned off) in my main browser (69.0.1) on Wayland and it doesn't work.*

And yes, I'm currently signed-in on my Fedora 31 desktop on a Gnome/Wayland session.

[*] just making sure my add-ons are not part of my problem.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

(In reply to itrymybest80 from comment #6)

I'm confused, tried the latest beta (firefox-70.0b13) and stable (firefox-69.0.3) and apparently they work too?

How do I know it's running on Wayland or is that built in by default, because I'm thinking it's on X11?

You need to run it with MOZ_ENABLE_WAYLAND=1 env variable. Then you find

Window Protocol: wayland

at about:support page.

Comment 8

[raklodder]

I did some more testing (ran 4 versions of Firefox, my current 69.0.1 (stable), 69.0.3 (stable), 70.0b13 (beta) and 71.0a1 (nighly) with "MOZ_ENABLE_WAYLAND=1" and checked about:support which said "Window Protocol Wayland" on all of my runs and I can confirm that my old problem is still in all versions, stable, beta and nightly,

but I also discovered what may be the cause of my issue (check both of my newly attached pictures), it works when I place my add-on icon/shortcuts on the right side of my browser window, while not on the left side of my screen on Wayland in fullscreen, windowed fullscreen and window, where input is offset.

Also while I was testing, I ran into a crash on Wayland in 70.0b13 while trying to change one of my add-on settings, I thought I'd seen some visual input on the add-on icon (left click to activate), but then Firefox crashed with the following error message:

ExceptionHandler::SendContinueSignalToChild sent continue signal to child
Gdk-Message: 13:29:14.372: Error 22 (Ogiltigt argument) dispatching to Wayland display.
Exiting due to channel error.
Sandbox: Unexpected EOF, op 0 flags 02400302 path /dev/shm/org.mozilla.ipc.28181.275
[Child 28181, Main Thread] WARNING: failed to open shm: In/ut-fel: file /builds/worker/workspace/build/src/ipc/chromium/src/base/shared_memory_posix.cc, line 250
Exiting due to channel error.
Exiting due to channel error.

Comment 9

[raklodder]

Attachment: no input (left)

Comment 10

[raklodder]

Attachment: full input (right)

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Can, can you please look at the left/right popup position issue? Is that something related to your recent popup work?

Comment 12

[Jan Horak [:jhorak]]

Looks like the move_to_rect issue when wayland popup placement moves the window because it does not fit to the screen. The pointer to the icon is not updated according to the shift made by wayland because the Firefox popup placement code from X11 is not used (and cannot be) .

We have to look at this one if we can do more about it.

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Do you still see the problem?
Thanks.

Comment 14

[shapeshifter]

Attachment: 200percent_ok.png

I can confirm this issue still exists in 84.0.1 and only at 300% scaling, but not 200%. See the attached screenshots.

Comment 15

[shapeshifter]

Attachment: 300percent_broken.png

This is using sway with: output "..." scale 3

Comment 16

[shapeshifter]

Sorry I meant to comment on #1633989

Comment 17

[shapeshifter]

Jeez, I mean #1633957...

Comment 18

[Martin Stránský [:stransky] (ni? me)]

Can you please test latest nightly under Wayland? A new popup handling code landed there.
Thanks.

Comment 19

[Martin Stránský [:stransky] (ni? me)]

Please re-test with new nightly as it gets another popup fixes.
Thanks.

Comment 20

[Martin Stránský [:stransky] (ni? me)]

I think this bug a bit diverged from the original report. Let's close this one and please open a new bug if you have any popup issues.
Thanks.