Closed Bug 1633957 Opened 4 years ago Closed 3 years ago

Hamburger menu, other popups too small and cut off in Wayland at 200% display scaling

Categories

(Core :: Widget: Gtk, defect, P3)

77 Branch
x86_64
Linux
defect

Tracking

()

RESOLVED DUPLICATE of bug 1718507
Tracking Status
firefox77 --- affected

People

(Reporter: andersk, Assigned: jhorak)

References

(Blocks 1 open bug)

Details

Attachments

(45 files)

48.51 KB, image/png
Details
113.38 KB, image/png
Details
32.42 KB, text/plain
Details
472.29 KB, image/png
Details
657.72 KB, image/png
Details
745.76 KB, image/png
Details
964.32 KB, image/png
Details
1.02 MB, image/png
Details
1.09 MB, image/png
Details
809.50 KB, image/png
Details
2.81 MB, image/jpeg
Details
124.51 KB, image/png
Details
1.25 MB, image/png
Details
930.50 KB, image/png
Details
35.45 KB, text/plain
Details
27.52 KB, text/plain
Details
149.44 KB, text/x-log
Details
1003.51 KB, image/png
Details
106.20 KB, image/png
Details
92.00 KB, application/octet-stream
Details
242.48 KB, image/png
Details
6.64 MB, video/x-matroska
Details
535.92 KB, image/png
Details
561.95 KB, image/png
Details
817.08 KB, image/png
Details
765.47 KB, image/png
Details
781.50 KB, image/png
Details
5.68 MB, image/jpeg
Details
2.19 MB, image/png
Details
2.11 MB, image/png
Details
2.20 MB, image/png
Details
2.11 MB, image/png
Details
1.20 MB, image/png
Details
1.84 MB, image/png
Details
114.97 KB, text/x-log
Details
319.28 KB, image/png
Details
376.36 KB, image/png
Details
284.80 KB, image/png
Details
310.95 KB, image/png
Details
6.76 MB, image/png
Details
6.67 MB, image/png
Details
6.65 MB, image/png
Details
7.00 MB, image/png
Details
5.47 MB, image/png
Details
94.57 KB, image/png
Details
Attached image screenshot

I’m running Firefox nightly on GNOME Shell 3.36.1, Wayland, NixOS 20.09. Using nightly 2020-04-22-09-35-42 and later, popups like the hamburger menu (☰) and site information (🔒) are shown in a window that’s too small, so that most of its content is cut off. See attached screenshot.

The problem does not occur using Xorg instead of Wayland; it also does not occur in nightly 2020-04-21-22-25-03 and earlier.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: General → Widget: Gtk
Product: Firefox → Core

Jan, can you look at it please?
Thanks.

Assignee: nobody → jhorak
Blocks: wayland
Flags: needinfo?(jhorak)
Priority: -- → P3
Blocks: wayland-popup
No longer blocks: wayland

I see the same thing in Sway, although the popup seems taller. The popup is scrollable.

The whole popup appears when running firefox through xwayland.

Currently on FF 76.0b8. Attaching screenshot.

Attached image popup-in-sway.png

Please, both of you, attach log obtained by:
export GDK_BACKEND="wayland" MOZ_LOG="Widget:5" firefox &>log
Thanks.

Flags: needinfo?(jhorak)

Here’s the requested log.

Some more experimenting has clarified which popups are affected: the first popup I open in my Firefox session is fine, and (at least for hamburger and site information popups) continues to be fine when opened subsequently, while popups that are not the first popup I opened are cropped to the small square.

I can no longer reproduce this in current nightlies. What about you, Luis?

Apologies @anders that I didn't see your message. I'm still having the problem, but looks like a potential fix just landed. Waiting on nightlies PPA to catch up for testing.

I see no change on FF 79.0b2. Popup (extensions and native) menus still render at size / scale_factor

I also have this problem for a while now.

I am running Fedora 32, Gnome, with Wayland. I am using the repo version of Firefox, and tried the firefox-wayland package.

I also tried downloading Firefox Nightly, installing it, and enabling Wayland support in the FireFox nightly image which is at version 81.0a1 (08-23-2020).

I get the exactly same behaviour in any version of Firefox that I've tried.

(In reply to luis.pabon from comment #4)

I see the same thing in Sway, although the popup seems taller. The popup is scrollable.

The whole popup appears when running firefox through xwayland.

Currently on FF 76.0b8. Attaching screenshot.

Not all pop-ups are scrollable for me. Extensions that do not anticipate having their frames resized and expect fixed size ratios don't present a scrollbar or respond to scrolling. Also the Bookmark feature native to firefox doesn't use a scrollbar when it is cut off, and cannot remove bookmarks even.

Attached image Hamburger - Scale 1.png

Hamburger menu - display scale 1

Attached image Hamburger - Scale 2.png

Hamburger menu - display scale 2

Attached image Hamburger - Scale 3.png

Hamburger menu - display scale 3

See the 3 screenshots above where I've manually changed the scale of my display to 1, 2 and 3 (I use scale 2 on that display).

Certainly looks like all menu pop ups (hamburger and extensions) on the address bar appear at exactly HEIGHT / SCALE_FACTOR. Width is unaffected.

I've attached three screenshots above, which show the problem of hidden unreachable content.
It was checked on Firefox 81.0a1 (2020-08-24) (64-bit), Wayland enabled (MOZ_ENABLE_WAYLAND=1), Sway WM with scaling set to "3", display is 13".

More info about the display:
$ swaymsg -t get_outputs
Output eDP-1 'Unknown 0x212B 0x00000000' (focused)
Current mode: 3840x2160 @ 60.001999 Hz
Position: 0,0
Scale factor: 3.000000
Scale filter: nearest
Subpixel hinting: unknown
Transform: normal
Workspace: 6
Max render time: off
Adaptive sync: disabled
Available modes:
1280x720 @ 59.966999 Hz
3840x2160 @ 48.028000 Hz
3840x2160 @ 60.001999 Hz

Is there any other way I can help to fix this annoying bug? It makes half of the features unusable for me.

I am also seeing this problem with Ctrl+Tab shows a list of recent tabs in a popup, and this view is not properly aligned tabs overlay each other too much. I think this may be also related to the root cause of this bug.

The other day, I installed Ubuntu 20.10, and this issue was no longer there. It behaved properly in HiDPI 125% scaling, showing the full extension window. I did not think to screen shot it unfortunately... I uninstalled it for other reasons, and went back to Fedora 33, where the issue is still present. The extension window is cut off short with HiDPI scaling in Fedora 33, but not Ubuntu 20.10.

Did you double checked that you switch to Wayland session in Ubuntu and Wayland support is enabled for Firefox? (MOZ_ENABLE_WAYLAND=1)

I'll check it with that this weekend to be very certain.

I have the same problem on Arch Linux, where I used the same Fedora-patched Firefox package (version 82.0). The issue only seems to appear when I scale by 300%, but not 200%.

I can confirm this issue still exists in 84.0.1 and only at 300% scaling, but not 200%. The attached screenshot is at 300%. I mistakenly commented in #1633989, where I also posted a 200% screenshot where no problem is visible.

Same issue. But I'm using fractional scaling at 125%.

Screenshot

Ubuntu 20.10 Wayland. Firefox 85.0.1 (Wayland).

Please test latest nightly on Wayland - we have a fixes for it there.
Thanks.

Flags: needinfo?(ari.birnbaum)

I see no changes - Firefox Nightly 88.0a1 (2021-02-24).
Actually there was no fixes for this issue since my first comment here (more that half a year ago).
I am permanently on Firefox Nightly just to get this fix as soon as it is released.

(In reply to Ari from comment #30)

Same issue. But I'm using fractional scaling at 125%.

Screenshot

Ubuntu 20.10 Wayland. Firefox 85.0.1 (Wayland).

How do you set scale factor to 125% and which DE do you use?

And guys with 300% issue, which DE do you have (sway only)?

Also please attach log from:
GDK_BACKEND="wayland" MOZ_LOG="Widget:5,WidgetPopup:5" firefox
(after opening the hamburger menu).

(In reply to Jan Horak [:jhorak] from comment #35)

(In reply to Ari from comment #30)

Same issue. But I'm using fractional scaling at 125%.

Screenshot

Ubuntu 20.10 Wayland. Firefox 85.0.1 (Wayland).

How do you set scale factor to 125% and which DE do you use?

gsettings set org.gnome.mutter experimental-features "['scale-monitor-framebuffer']" on GNOME 3.38.3. If that doesn't work, manually edit the mutter setting through a dconf edtior.

Also please attach log from:
GDK_BACKEND="wayland" MOZ_LOG="Widget:5,WidgetPopup:5" firefox
(after opening the hamburger menu).

I'm unfamiliar with Bugzilla. How would I add an attachment?
Here is a Dropbox link for the time being: https://www.dropbox.com/s/7q4s2xj168fn3zk/log?dl=0

Flags: needinfo?(ari.birnbaum)

(In reply to Martin Stránský [:stransky] from comment #31)

Please test latest nightly on Wayland - we have a fixes for it there.
Thanks.

Sadly, the issue is still reproducible for me on Nightly 88.0a1 (2021-02-24) (64-bit).

Attached file moz-log.txt

I am attaching a log with the output from your command, after opening Firefox and clicking an overlay menu button. I am running FF 85.0.1 on Fedora 33 with 125% scaling.

From what I can tell, the bug is exclusive to Gnome3 with Wayland, and works normally when firefox is launched by the X manager.

The bug seems to get more dramatic the higher your fracional scaling is set to. 125% for me, has the largest screen real estate, and more of the overlay menu appears, and if I increase scaling to 150% or higher, then the overlay menus get cut off even more than before.

The following command enables fractional scaling in Gnome, unlocking the extra scaling levels between 100% and 200% in the gnome Settings under Display.
gsettings set org.gnome.mutter experimental-features "['scale-monitor-framebuffer']"

Attached file nightly-log.txt

And this is the output of running the same command against Firefox Nightly 88.0a1, which has the same behaviours still.

(In reply to Jan Horak [:jhorak] from comment #35)

(In reply to Ari from comment #30)

How do you set scale factor to 125% and which DE do you use?

And guys with 300% issue, which DE do you have (sway only)?

Also please attach log from:
GDK_BACKEND="wayland" MOZ_LOG="Widget:5,WidgetPopup:5" firefox
(after opening the hamburger menu).

I have Sway only, but my system may have some bits of Gnome and KDE also installed (I've tried them, never used, don't remember is I fully removed it from my system).

For some time now I've been running Firefox nightly with this command: MOZ_ENABLE_WAYLAND=1 exec firefox "$@" .

I've also attached logs from running GDK_BACKEND="wayland" MOZ_LOG="Widget:5,WidgetPopup:5" firefox.

(In reply to Jan Horak [:jhorak] from comment #35)

And guys with 300% issue, which DE do you have (sway only)?

Also please attach log from:
GDK_BACKEND="wayland" MOZ_LOG="Widget:5,WidgetPopup:5" firefox
(after opening the hamburger menu).

Sorry for the late reply. I am willing to test any new fixes or provide any other help for this, as this is really annoying for me.
I will also reply in time.

Just in case, the issue is still present. Firefox 89.0a1 (2021-03-22) (64-bit).

Also experience this issue with Kubuntu 21.04 Wayland session, Firefox 88.0.1 Release.

Cannot click "save" button extension options

I've also got a bunch of empty files like "firefox_wayland_debug.log.child-9.moz_log".

Can you please test latest nightly under Wayland? A new popup handling code landed there.
Thanks.

(In reply to Martin Stránský [:stransky] (ni? me) from comment #48)

Can you please test latest nightly under Wayland? A new popup handling code landed there.
Thanks.

Sadly, still occurring for me. FF Nightly 91.0a1 (2021-06-01) (64-bit). Fresh installation of Ubuntu 21.04.

Unfortunately the main menu popup is still half-sized and the overflowed/cut extension popups cannot be scrolled.

I have no idea how or why but today it suddenly just showed correct and the hamburger menu also correct. Then i closed Firefox and opened it again and it was again broken/small.

Today I noticed some improvements for a few popups, while other popups are still having this issue.
Firefox version: 91.0a1 (2021-06-15) (64-bit).
This is on 13" 4k (UHD) display with scaling factor x3, on sway wm.

I am attaching screenshots below.

Also the behavior changes when I connect additional monitor, so that there are two monitors: my laptop (13", 4k, scaling x3 (300%)) and external monitor (27", 4k, scaling x2 (200%)).
In short - with two Firefox windows on different monitors, now almost all works correctly on my laptop display (13"), but almost no popups work on at all on my external monitor (27").

I will attach screenshots with this setup below.

Please re-test with new nightly as it gets another popup fixes.
Thanks.

Issue still occurring sadly. I'd like someone else to confirm this, but on 91.0a1 (2021-06-16) (64-bit) the issue now also occurs for me with no scaling applied (e.g. 100%).

(In reply to Ari from comment #66)

Issue still occurring sadly. I'd like someone else to confirm this, but on 91.0a1 (2021-06-16) (64-bit) the issue now also occurs for me with no scaling applied (e.g. 100%).

Can you please attach a screenshot of it?
Thanks.

Flags: needinfo?(ari.birnbaum)

This will sound odd, but I just relaunched nightly to take the screenshot and the issue is now solved for me with and without fractional scaling!

Command used: env MOZ_ENABLE_WAYLAND=1 ./firefox
91.0a1 (2021-06-16) (64-bit).

Screenshot

Flags: needinfo?(ari.birnbaum)

To make matters more confusing, I just tested again, and it is occurring again. Now it is happening with no scaling as well.

Screenshot

I'm not sure how to reproduce this issue now, but I'm realizing it is important to mention I've been testing with dual monitors. One monitor set to 100% scale and the other set to 125% scale. Should that have any effect on this?

Please keep me posted if you need any more details, especially given the inconsistency.

With today's nightly, I'm still seeing two issues. I'm running Sway with 200% scaling set via output eDP-1 scale 2 in the configuration. I'll attach screenshots and the log momentarily.

  1. The hamburger menu popup is still only ~half the available screen height, but the content fits and scrolls properly within it.
  2. Extension popups (I used uBlock Origin as an example, but it seems to be pretty general) are both small and have their content cut off without scrolling.
Attached image firefox-hamburger.png
Attached image firefox-ublock.png
Attached file firefox.log

MOZ_LOG="Widget:5,WidgetPopup:5" output

Build 20210616094608, KDE Plasma 5.22 with 125% scaling. Issue doesn't seem to be resolved. The hamburger menu is small (shorter than Firefox 89 Release). Both Firefox 89 and Firefox Nightly have scrolling hamburger menu. Both have this issue.

I see no changes. The only thing that changes since yesterday morning for me - Firefox crashed about 10-15 times, when I was opening tabs and bookmarks, and closing the bookmarks sidebar.

I will attach a few screenshots with only 1 monitor active (13", 4k, scaling 300%), sway wm.

With two monitor setup, some popups show from time to time (I need to click about 2-5 times in a row on it) (this was already the case), some shows correctly from the first click. And it still happens that in some time the Firefox window UI just freezes on the additional monitor, and I need to switch workspaces (go to another workspace on this monitor, then go back to the workspace with Firefox window), then Firefox window is properly refreshed, but still if I Ctrl+Tab for example - it won't refresh. So this one happens only when the Firefox window in on the additional monitor.

PS: two monitors: my laptop (13", 4k, scaling x3 (300%)) and external monitor (27", 4k, scaling x2 (200%)).

So looks like nothing changed for me here since yesterday, except crashes (it was not crashing before).

This one opens on first time clicking - works correctly.

This one opens on first time clicking - works correctly.

"Always open in container" (in the address bar) - doesn't open. Clicked about 10 times in a row.

"Save to Pocket" popup opens from time to time, you can see that the mouse cursor detects some elements as clickable, but the popup is not visible.

This is the case when UI is frozen. Being at the last tab I clicked on each of the extensions pictures at the right part of Firefox bar, (this was probably the moment when is all got frozen), then I clicked on the tab next to the last, and you see on the screenshot the result.

I want to emphasize that those last comments, about 2 monitor setup, the issue described occurs only on the Firefox window which is placed on the external monitor.

Please let me know If you need any logs or any additional steps for me to take. I am willing to help.

How I run Firefox:

$ cat /home/kp/.bin/firefox-nightly
#!/bin/sh
exec env MOZ_ENABLE_WAYLAND=1 /home/kp/.bin/firefox-nightly.d/firefox "$@"

My env:

$ env
SHELL=/bin/bash
COLORTERM=truecolor
QT_WAYLAND_DISABLE_WINDOWDECORATION=1
HISTSIZE=2000
I3SOCK=/run/user/1000/sway-ipc.1000.1284.sock
GRADLE_HOME=/usr/share/java/gradle
XCURSOR_SIZE=24
CLOUDSDK_PYTHON_ARGS=-S
XDG_SEAT=seat0
PWD=/home/kp
LOGNAME=kp
XDG_SESSION_TYPE=wayland
SYSTEMD_EXEC_PID=445
MOTD_SHOWN=pam
HOME=/home/kp
LANG=en_US.UTF-8
_JAVA_AWT_WM_NONREPARENTING=1
XDG_CURRENT_DESKTOP=sway
VTE_VERSION=5602
CLOUDSDK_ROOT_DIR=/opt/google-cloud-sdk
SWAYSOCK=/run/user/1000/sway-ipc.1000.1284.sock
WAYLAND_DISPLAY=wayland-1
INVOCATION_ID=4e5cb8ef21124dde8de9f8606ed4ed0a
QT_QPA_PLATFORM=wayland
CLOUDSDK_PYTHON=python
GEM_HOME=/home/kp/gems
XDG_SESSION_CLASS=user
TERM=xterm-termite
GOOGLE_CLOUD_SDK_HOME=/opt/google-cloud-sdk
USER=kp
DISPLAY=:0
SHLVL=1
MOZ_ENABLE_WAYLAND=1
XDG_VTNR=1
XDG_SESSION_ID=1
XDG_RUNTIME_DIR=/run/user/1000
WLR_DRM_NO_MODIFIERS=1
JOURNAL_STREAM=8:24577
XDG_DATA_DIRS=/home/kp/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share/:/usr/share/
PATH=/home/kp/gems/bin:/home/kp/gems/bin:/opt/google-cloud-sdk/bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/usr/lib/jvm/default/bin:/usr/bin/site_perl:/usr/bin/vendor_perl:/usr/bin/core_perl:/home/kp/.bin:/home/kp/.local/share/gem/ruby/3.0.0/bin:/home/kp/.bin:/home/kp/.local/share/gem/ruby/3.0.0/bin
DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus
MAIL=/var/spool/mail/kp
_=/usr/bin/env

Frankly I'm lost in the comments here. Please file a new bugs, one per each issue and post Bugs ID here. (Also file the crash as a new bug).
Thanks.

Flags: needinfo?(konstantin.ponomarenko)

(In reply to Martin Stránský [:stransky] (ni? me) from comment #89)

Frankly I'm lost in the comments here. Please file a new bugs, one per each issue and post Bugs ID here. (Also file the crash as a new bug).
Thanks.

Sure. Sorry for putting this all tighter in one issue.

Here are other issues which I am experiencing:
[wayland] After restart, container tabs are open as regular tabs: https://bugzilla.mozilla.org/show_bug.cgi?id=1717189
[wayland] "List All Tabs" popup doesn't open on the second monitor: https://bugzilla.mozilla.org/show_bug.cgi?id=1717192
[wayland] Firefox menu doesn't open when clicked, on the second monitor: https://bugzilla.mozilla.org/show_bug.cgi?id=1717195
[wayland] Firefox UI freezes after clicking right click on a tab and trying to select menu options: https://bugzilla.mozilla.org/show_bug.cgi?id=1717197

As for this particular bug - "Firefox popups cut off and incorrectly sized with display scaling on Wayland" - should it still be tracked here?
Or should it be one dedicated issue/bug per popup (e.g.: one for menu, one for bookmarks, one for Bitwarden, one for Containers addon, etc ...)?

Flags: needinfo?(konstantin.ponomarenko)

Has anyone found a workaround for the issue I wrote about here?

I'm running
Fedora 34
Sway 1.6
Firefox 89.0

I use 200% scaling.

The menu is still cut off.

Firefox 90 Ctrl Tab improvement

... But still not centered but located near the top left corner of Firefox window.

Hello, I have the same bug with 2 monitors with 100% (Primary) and 125% (Secondary). The hamburger menu when I open a window in my secondary monitor is cutted off

(In reply to Sergio from comment #94)

Hello, I have the same bug with 2 monitors with 100% scalling (Primary) and 125% (Secondary). The hamburger menu when I open a window in my secondary monitor is cutted off

Should be dupe of Bug 1718507.

Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE

LOL, biggest dupe i've ever seen.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: