LSNG: Force kill database actors during shutdown
Categories
(Core :: Storage: localStorage & sessionStorage, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | unaffected |
| firefox70 | --- | fixed |
| firefox71 | --- | fixed |
People
(Reporter: janv, Assigned: janv)
References
(Blocks 1 open bug)
Details
Crash Data
Attachments
(1 external file, 1 obsolete file)
This is an attempt to fix remaining LSNG shutdown hangs.
| Assignee | ||
Comment 1•7 years ago
|
||
Database actors are force killed after 5 seconds if the child side doesn't
respond to the RequestAllowToClose message during shutdown.
| Assignee | ||
Updated•7 years ago
|
Comment 3•7 years ago
|
||
| bugherder | ||
| Assignee | ||
Updated•7 years ago
|
| Assignee | ||
Updated•7 years ago
|
| Assignee | ||
Updated•7 years ago
|
| Assignee | ||
Comment 4•7 years ago
|
||
Comment on attachment 9100290 [details]
Bug 1587931 - LSNG: Force kill database actors during shutdown; r=asuth
Beta/Release Uplift Approval Request
- User impact if declined: Users experience more shutdown hangs
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Medium
- Why is the change risky/not risky? (and alternatives if risky): Medium risk given we are very close to 70 release. The patch is quite simple though and Nightly shows significant reduction of shutdown hangs.
- String changes made/needed: None
| Assignee | ||
Comment 5•7 years ago
|
||
Just to be clear, the patch would be intended for Firefox 70 uplift.
| Assignee | ||
Comment 6•7 years ago
|
||
Database actors are force killed after 5 seconds if the child side doesn't
respond to the RequestAllowToClose message during shutdown.
| Assignee | ||
Comment 7•7 years ago
|
||
The last attachment is for potential 70 branch uplift.
| Assignee | ||
Comment 8•7 years ago
|
||
Comment on attachment 9100827 [details]
Bug 1587931 - LSNG: Force kill database actors during shutdown; r=asuth
Beta/Release Uplift Approval Request
- User impact if declined: Users experience more shutdown hangs
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Medium
- Why is the change risky/not risky? (and alternatives if risky): Medium risk given we are very close to 70 release. The patch is quite simple though and Nightly shows significant reduction of shutdown hangs.
- String changes made/needed: None
| Assignee | ||
Updated•7 years ago
|
| Assignee | ||
Updated•7 years ago
|
| Assignee | ||
Comment 9•7 years ago
•
|
||
This fix significantly reduced LocalStorage shutdown hangs.
Updated•7 years ago
|
Comment 10•7 years ago
|
||
Comment on attachment 9100827 [details]
Bug 1587931 - LSNG: Force kill database actors during shutdown; r=asuth
Getting rid of some of those crashes would be great, let's take this gamble.
Updated•7 years ago
|
Comment 11•7 years ago
|
||
| bugherder uplift | ||
Updated•7 years ago
|
| Assignee | ||
Comment 12•7 years ago
•
|
||
This didn't regress bug 1592336, it actually reduced shutdown hangs.
Updated•6 years ago
|
Description
•