1588197 - Add autoplay to our permissions policies

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement, P3)

Description

[Mike Kaply [:mkaply]]

We should add autoplay to our permissions policies:

Services.perms.add(NetUtil.newURI("https://www.youtube.com"), "autoplay-media", 1);

Comment 1

[Jayde Yue]

Hi there,

I am an UofT CS student doing bug-hunting for a course. Here is the link to my report for this bug https://github.com/JaydeYue/gecko-dev/blob/master/docs/A3.md, lmk if there is anything else I need to do. I will try to test it next weekend or whenever I have time.

Cheers,
Jayde

Comment 2

[Mike Kaply [:mkaply]]

This should only require a chance to policies-schema.json and Policies.jsm.

Looking at

https://bugzilla.mozilla.org/show_bug.cgi?id=1467062

should provide some guidance.

Also, we don't use Github for patches to the tree.

See

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

Comment 3

[Mike Kaply [:mkaply]]

Thank you for working on this, by the way!

Comment 4

[Jayde Yue]

Alright, feel free to assign this to me, I will see this through.

Comment 5

[Mike Kaply [:mkaply]]

Jayde: Are you planning to finish this bug?

Thanks

Comment 6

[Taylor Southorn]

Hi Mike, I've added added autoplay to both the policies.jsm and policies-schema.json, will it also be included in the browser_policy_permissions.js?

Comment 7

[Taylor Southorn]

Attachment: Bug 1588197 - Add autoplay to our permissions policies. r=mkaply

Comment 8

[Mike Kaply [:mkaply]]

Yes, you should add changes to https://searchfox.org/mozilla-central/source/browser/base/content/test/permissions/browser_permissions.js

for the test.

Comment 9

[Mike Kaply [:mkaply]]

Reassigning due to lack of info from original contributor.

Comment 10

[Taylor Southorn]

Attachment: Bug 1588197 - Add autoplay to our permissions policies. r=mkaply

Comment 11

[Mike Kaply [:mkaply]]

Are you going to do this last change?

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/572a42a3fffb
Add autoplay to our permissions policies. r=mkaply,fluent-reviewers,Gijs,flod

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/572a42a3fffb

Comment 14

[Mike Kaply [:mkaply]]

Comment on attachment 9113365 [details]
Bug 1588197 - Add autoplay to our permissions policies. r=mkaply

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy updates
• User impact if declined: Unable to set autoplay via policy.
• Fix Landed on Version: 74
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Policy only, has automated test.
• String or UUID changes made by this patch: Adds new string to change text. Policy strings are approved for English only for ESR.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9113365 [details]
Bug 1588197 - Add autoplay to our permissions policies. r=mkaply

Policy engine update needed for Fx74 parity. Approved for 68.6esr.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/2cf9e0c91d51