Add autoplay to our permissions policies
Categories
(Firefox :: Enterprise Policies, enhancement, P3)
Tracking
()
People
(Reporter: mkaply, Assigned: southort)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file, 1 obsolete file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr68+
|
Details | Review |
We should add autoplay to our permissions policies:
Services.perms.add(NetUtil.newURI("https://www.youtube.com"), "autoplay-media", 1);
Reporter | ||
Updated•5 years ago
|
Hi there,
I am an UofT CS student doing bug-hunting for a course. Here is the link to my report for this bug https://github.com/JaydeYue/gecko-dev/blob/master/docs/A3.md, lmk if there is anything else I need to do. I will try to test it next weekend or whenever I have time.
Cheers,
Jayde
Reporter | ||
Comment 2•5 years ago
|
||
This should only require a chance to policies-schema.json and Policies.jsm.
Looking at
https://bugzilla.mozilla.org/show_bug.cgi?id=1467062
should provide some guidance.
Also, we don't use Github for patches to the tree.
See
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
Reporter | ||
Comment 3•5 years ago
|
||
Thank you for working on this, by the way!
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 5•5 years ago
|
||
Jayde: Are you planning to finish this bug?
Thanks
Assignee | ||
Comment 6•5 years ago
|
||
Hi Mike, I've added added autoplay to both the policies.jsm and policies-schema.json, will it also be included in the browser_policy_permissions.js?
Assignee | ||
Comment 7•5 years ago
|
||
Reporter | ||
Comment 8•5 years ago
|
||
Yes, you should add changes to https://searchfox.org/mozilla-central/source/browser/base/content/test/permissions/browser_permissions.js
for the test.
Reporter | ||
Comment 9•5 years ago
|
||
Reassigning due to lack of info from original contributor.
Assignee | ||
Comment 10•5 years ago
|
||
Updated•5 years ago
|
Comment 12•5 years ago
|
||
Comment 13•5 years ago
|
||
bugherder |
Reporter | ||
Comment 14•5 years ago
|
||
Comment on attachment 9113365 [details]
Bug 1588197 - Add autoplay to our permissions policies. r=mkaply
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Policy updates
- User impact if declined: Unable to set autoplay via policy.
- Fix Landed on Version: 74
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Policy only, has automated test.
- String or UUID changes made by this patch: Adds new string to change text. Policy strings are approved for English only for ESR.
Comment 15•5 years ago
|
||
Comment on attachment 9113365 [details]
Bug 1588197 - Add autoplay to our permissions policies. r=mkaply
Policy engine update needed for Fx74 parity. Approved for 68.6esr.
Comment 16•5 years ago
|
||
bugherder uplift |
Reporter | ||
Updated•4 years ago
|
Description
•