1588218 - Expose DNS suffix list (Android)

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P1)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Hi James,

I found this Android API https://developer.android.com/reference/android/net/LinkProperties.html#getDomains() that seems to give me exactly what I need. I was considering calling it from GeckoAppShell.java like we do for ex. isNetworkLinkUp
The problem is that LinkProperties is API level 21+ but the wiki says GeckoView requires Android OS version 4.3 (API Level 18) or later. For comparison, Fennec supports Android 4.1 (API level 16) and later. Fenix and Focus support Android 5.0 (API level 21) and later.. Do we need to worry about pre API level21 platforms?

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1588218 - Expose DNS suffix list (Android) r=michal!,snorp!

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

We do need to care about API < 21 for now. In this case, simply returning an empty list will probably suffice in that situation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6384318223b4
Expose DNS suffix list (Android) r=michal,snorp

Comment 5

[Dorel Luca [:dluca]]

Backed out changeset 6384318223b4 (bug 1588218) for Linting failure on mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoAppShell.java. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=275665365&repo=autoland&lineNumber=1110

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=6384318223b46b1513240125d11aa6bf99eb0c00

Backout:
https://hg.mozilla.org/integration/autoland/rev/46cd6386dfdac604ecfa1fbbe560fd88dd23e4f7

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d2a7cb4d6ff
Expose DNS suffix list (Android) r=michal,snorp

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/2d2a7cb4d6ff