1595611 - Consider caching ConnectivityManager in GeckoAppShell.java

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

https://phabricator.services.mozilla.com/D51561#1594289

This can be somewhat slow, so if we plan to call this a lot we should consider caching the ConnectivityManager.

We have a bunch of methods that use the ConnectivityManager, so we may want to actually do that.

Comment 1

[Sonakshi Saxena]

(In reply to Valentin Gosu [:valentin] (he/him) from comment #0)

https://phabricator.services.mozilla.com/D51561#1594289

This can be somewhat slow, so if we plan to call this a lot we should consider caching the ConnectivityManager.

We have a bunch of methods that use the ConnectivityManager, so we may want to actually do that.

Hey [:valentin]
Would like to work on this. Can I take this too?

Thanks!

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Sure, you're welcome to work on it.
Make sure to set your Android env according to this: https://mozilla.github.io/geckoview/

Comment 3

[Sonakshi Saxena]

Attachment: Bug 1595611 - Cache ConnectivityManager in GeckoAppShell r=snorp

Comment 4

[Sonakshi Saxena]

Hey [:snorp]
Can you please review the patch?
Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/919791773dac
Cache ConnectivityManager in GeckoAppShell r=snorp

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/919791773dac