1588298 - Ensure CreateFromLoadURIOptions passes the appropriate PRIVATE flag to URIFixup

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Marco Bonardo [:mak]]

Bug 1578624 moved the urifixup call from the docshell to CreateFromLoadURIOptions, that is now also invoked by BrowsingContext.
That code must pass FIXUP_FLAG_PRIVATE_CONTEXT to URIFixup when appropriate.

We need a test that goes through both branches in CreateFromLoadURIOptions, either if the consumer is a DocShell or if it's an EmbedderElement.
The DocShell has information about PB mode.

Comment 1

[Matt Woodrow (:mattwoodrow)]

It seems like private browsing state should be stored on the BrowsingContext itself (or the BC Group?), which would then make this super easy to fix.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1588298 - Ensure CreateFromLoadURIOptions passes the appropriate PRIVATE flag to URIFixup. r=kmag

Comment 3

[Marco Bonardo [:mak]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #1)

It seems like private browsing state should be stored on the BrowsingContext itself (or the BC Group?), which would then make this super easy to fix.

Oh sorry, I didn't see your comment before attaching this, do you have a simple proposal to implement? Would my patch be ok in the meanwhile, or is the "proper" fix straight-forward enough? We need this fix in Firefox 71.

Comment 4

[Marco Bonardo [:mak]]

Kris reviewed the current patch, I'm happy to file a follow-up for a broader fix if you think it would be cleaner long term, just let me know.

Comment 5

[Kris Maglione [:kmag]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #1)

It seems like private browsing state should be stored on the BrowsingContext itself (or the BC Group?), which would then make this super easy to fix.

For what it's worth, this is already on the TODO list, along with storing the entire OriginAttributes for a DocShell on the BrowsingContext. I'd be happy to accept a patch for either or both.

Comment 6

[Matt Woodrow (:mattwoodrow)]

I think I'll need both of those for 'start parent initiated loads from the parent process' anyway, so I can look in them.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57c7f2d2d1d5
Ensure CreateFromLoadURIOptions passes the appropriate PRIVATE flag to URIFixup. r=kmag

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/57c7f2d2d1d5