1588516 - Calendar start-up fails if AppMenu button is missing from toolbar

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect, P1)

Description

[romuald.poteau]

Attachment: Screenshot_20191014_155250.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.120 Safari/537.36

Steps to reproduce:

Nothing special. Permanent bug

Actual results:

The colors of the events are all all the same, i.e. light grey, whatever the calendar is

Expected results:

Each event should appear with a darker color and a color mark associated to a given calendar

Comment 1

[Richard Leger]

Which version of Thunderbird and Lightning are you using?

Local calendar or CalDav network or Calendar or Google network calendar or else?

Is it happening in Day and Month view as well?

What do you mean by Calendar is unusable?

Comment 2

[Richard Leger]

Also which Linux distro and version do you use?

Comment 3

[accounts+github]

I have the same issue.
I'm using Xubuntu 19.10 (Linux trill 5.3.0-19-generic #20-Ubuntu SMP Fri Oct 18 09:04:39 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux)
This is with both CalDav calendars and Provider for Google Calendar calendars.

I restarted Thunderbird (and my laptop) several times and the color was always missing.
Now I started Thunderbird from the commandline to see if I could get some additional information, and miraculously the colors are back....

Comment 4

[Richard Leger]

Which version of TB and Lightning do you use?

Comment 5

[accounts+github]

TB 68.1.2 (64-bit), the default one from the Ubuntu repository
Lightning also says 68.1.2 as version number (Last updated on Nobember 10, 2019)

Comment 6

[Richard Leger]

It seems issue follow an update...

@accounts,
Would you know or recall which version of TB and Lightning were in use before last updated Nov 10th?
Which command did you run that seemed to have fixed issue?

@Romuald,
Did the issue fixed itself for you as well?
If not, can you try start Thunderbird via command line?
If still not fixed can you provide version for OS, Thunderbird, Lightning...

Cheers,

Comment 7

[Tim McCormack]

I'm on Debian Linux 10 ("buster"), and this started for me today after the following apt upgrade came through:

• Upgraded thunderbird 1:60.9.0-1~deb10u1 to 1:68.2.2-1~deb10u1
• Upgraded lightning from 1:60.9.0-1~deb10u1 to 1:68.2.2-1~deb10u1
• Removed calendar-google-provider

I have no other extensions. Starting from the command line as thunderbird does not resolve this.

(Full system info: Linux 4.19.0-6-amd64 #1 SMP Debian 4.19.67-2+deb10u2 (2019-11-11) x86_64 GNU/Linux)

Comment 8

[Richard Marti (:Paenglab)]

Try to rename xulstore.json in your profile with closed Thunderbird. This resets all your window positions and button customizing.

Comment 9

[Richard Leger]

If renaming xulstore.json would not work for some reason, you may try to change colors again as a possible work around, have you tried already perhaps?

To Edit the Calendar Colours, go to the Calendar View and right click on the calandar concerned and select Properties.... Click on the colour panel to change colour.

Now for the Categories go to Tools > Options >Lightning ... Select the Categories tab, and click on the Category in question and click on Edit...

Can you also described your calendars, are they local, network caldav and/or network google?

If you can tell, does issue happens to all those types of Calendar or only certain type?

Comment 10

[Tim McCormack]

My calendars (or at least, all the ones enabled and with visible events) are all local. Changing calendar colors doesn't seem to have any effect, even after application restart. Renaming xulstore.json certainly makes the interface change, but doesn't restore the colors. Calendar colors seem to be stored in prefs.js, like user_pref("calendar.registry.SOME-UUID.color", "#668cff"); both before and after the upgrade.

Comment 11

[accounts+github]

(In reply to Richard Leger from comment #6)

It seems issue follow an update...

@accounts,
Would you know or recall which version of TB and Lightning were in use before last updated Nov 10th?
Which command did you run that seemed to have fixed issue?

The problem started right after I upgraded Xubuntu from 19.04 to 19.10, so the version I had before was the default version from Ubuntu 19.04, which is probably 60.x?

Meanwhile I had to restart my laptop and the colors are gone again. I tried restarting Thunderbird several times (both from the CLI and using the .desktop file) and results seem to be random. Most of the times the colors are not working, and in a few cases I suddenly had colors.
I also don't think the problem is really with the colors of the specific calendars: I use a dark color theme and when the colors work, Lightning also uses a dark background. When the colors are 'transparent' the background of lightning itself is white. Also, when the colors are not shown correctly the buttons to switch to day / week / month view, and the next / previous buttons don't work.
When I start Thunderbird from CLI I noticed the following line of output, which I believe does not show up when the colors load correctly:

JavaScript error: chrome://calendar/content/calendar-chrome-startup.js, line 175: TypeError: button is null

Comment 12

[accounts+github]

renaming xulstore.json to something else seems to fix the problem indeed. One special thing I did (many years ago) was to move the few buttons I needed onto the tab bar and disable the toolbars.

Comment 13

[WaltS48 [:walts48]]

Reporter,

Did renaming xulstore.json in your profile with Thunderbird closed fix the problem for you?

Comment 14

[Richard Leger]

@all,
Has anyone file a distro bug about the issue at Debian and/or Ubuntu? The pb could also be distro package upgrade issue potentially...

(In reply to accounts+github from comment #12)

renaming xulstore.json to something else seems to fix the problem indeed.

@accounts,
After renaming the file, have you tried to restart your laptop (and TB) multiple times again to check that the fix "holds"? Just wondering as you seems to say your issue was random...

@Tim,
If you clear cache and cookies in Thunderbird, does that make any difference in the color issue?
https://ccm.net/faq/32358-thunderbird-clear-cache-cookies-and-recent-history
I doubt it would but I thought it may be worth a try perhaps...
Apart from Lightning do you use any other add-ons? If yes, would you be able to temporary disable them all but Lightning and check if color issue still appears? This is just to exclude any other add-on as possibly interfering somehow...

Comment 15

[Geoff Lankow (:darktrojan)]

(In reply to accounts+github from comment #11)

JavaScript error: chrome://calendar/content/calendar-chrome-startup.js, line 175: TypeError: button is null

That's not good. If the hamburger menu button is not in the toolbar this code will fail and take out the rest of the start-up. I'll fix it.

Comment 16

[accounts+github]

(In reply to Geoff Lankow (:darktrojan) from comment #15)

(In reply to accounts+github from comment #11)

JavaScript error: chrome://calendar/content/calendar-chrome-startup.js, line 175: TypeError: button is null

That's not good. If the hamburger menu button is not in the toolbar this code will fail and take out the rest of the start-up. I'll fix it.

I just tested this: from the Calendar Toolbar I removed the AppMenu button and restarted Thunderbird. Then the colors of the Calendars (and background) are indeed broken. After adding the AppMenu button back onto the Calendar Toolbar and restarting Thunderbird, Calendars are back as expected. I guess this might have been my problem.

Comment 17

[Geoff Lankow (:darktrojan)]

Attachment: 1588516-calendar-appmenu-button-1.diff

Comment 18

[Paul Morris [:pmorris]]

Comment on attachment 9110083 [details] [diff] [review]
1588516-calendar-appmenu-button-1.diff

Review of attachment 9110083 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks.  This patch fixed the problem when I tested it (by removing the appmenu from the calendar toolbar and restarting).

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1bc27f2370ac
Find calendar AppMenu buttons in the palette when not in the toolbar. r=pmorris

Comment 20

[Tim McCormack]

Earlier, I couldn't get colors to return either by repeatedly restarting Thunderbird or by moving xulstore.json out of the way. But after a few cycles of upgrade and restore, it's currently working, as another person has reported. Perhaps there's a race condition here? But I'm not sure how it would happen.

Perhaps relatedly, I do see the AppMenu button on my Calendar toolbar in 68.2.2. (It's the one with three horizontal lines, no?) If I use Customize to remove it from the bar, then restart Thunderbird, the button reappears!

Comment 21

[Stefan Sitter [:ssitter]]

(In reply to Tim McCormack from comment #20)

If I use Customize to remove it from the bar, then restart Thunderbird, the button reappears!

Customize toolbar don't work is known problem in 68 (Lightning Bug 1582888 -> Thunderbird Bug 1584160). Based on 1584160 it ought to be fixed with upcoming 68.3 release.

Comment 22

[Geoff Lankow (:darktrojan)]

71 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/c5e0a5542802fa67c10f1bf93b340027ad46630b

Comment 23

[Geoff Lankow (:darktrojan)]

ESR 68.3:
https://hg.mozilla.org/releases/comm-esr68/rev/d30283e9f671d611b40e9c674fa6e43dab2f88b1