Closed
Bug 1588522
Opened 5 years ago
Closed 1 year ago
QM: CheckTemporaryStorageLimits may block shutdown
Categories
(Core :: Storage: Quota Manager, defect, P3)
Core
Storage: Quota Manager
Tracking
()
RESOLVED
FIXED
109 Branch
| Tracking | Status | |
|---|---|---|
| firefox109 | --- | fixed |
People
(Reporter: janv, Assigned: hsingh)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I reported this issue in bug 1541776 comment 29. The loop that deletes files can just check if we are shutting down and early return from the method. Deleting files in that method is not essential (it's not a privacy related clear), so we can't just abort that operation. Files will be deleted next time temporary storage is initialized.
|
Assignee | |
Comment 1•2 years ago
|
||
QuotaManager::CheckTemporaryStorageLimits has been renamed to QuotaManager::CleanupTemporaryStorage in revision 632843:6f8259958012
|
|
Assignee | |
Comment 2•2 years ago
|
||
We are iterating to remove origins (ones which are over group and global storage limits) in QuotaManager::ClearOrigins. This seems to be the good where we could skip deleting origins if we are shutting down.
|
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → hsingh
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
||
Updated•2 years ago
|
Attachment #9286801 -
Attachment description: WIP: Bug 1588522: Stop cleaning up temporary files when shutting down.r=#dom-storage-reviewers,janv → Bug 1588522: Stop cleaning up temporary files when shutting down.r=#dom-storage-reviewers,janv
|
||
Updated•2 years ago
|
Severity: normal → S3
|
|
||
Updated•2 years ago
|
Severity: normal → S3
Pushed by hsingh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/102a02d212a0 Stop cleaning up temporary files when shutting down.r=janv,jstutte
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox109:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•