1588522 - QM: CheckTemporaryStorageLimits may block shutdown

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect, P3)

Description

[Jan Varga [:janv]]

I reported this issue in bug 1541776 comment 29. The loop that deletes files can just check if we are shutting down and early return from the method. Deleting files in that method is not essential (it's not a privacy related clear), so we can't just abort that operation. Files will be deleted next time temporary storage is initialized.

Comment 1

[Harveer Singh]

QuotaManager::CheckTemporaryStorageLimits has been renamed to QuotaManager::CleanupTemporaryStorage in revision 632843:6f8259958012

Comment 2

[Harveer Singh]

We are iterating to remove origins (ones which are over group and global storage limits) in QuotaManager::ClearOrigins. This seems to be the good where we could skip deleting origins if we are shutting down.

Comment 3

[Harveer Singh]

Attachment: Bug 1588522: Stop cleaning up temporary files when shutting down.r=#dom-storage-reviewers,janv

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/102a02d212a0
Stop cleaning up temporary files when shutting down.r=janv,jstutte

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/102a02d212a0