Closed Bug 1588637 Opened Last month Closed Last month

Optimize quick open component

Categories

(DevTools :: Debugger, defect, P3)

71 Branch
defect

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: sorin.davidoi, Assigned: sorin.davidoi)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

Type in the quick open input field while loading an application with ~80 bundles that are source-mapped to ~4000 files.

Actual results:

The debugger dropped a lot of frames and became unresponsive for seconds.

Expected results:

It should be more snappy.

Apply the following optimizations:

  • Don't use regular expressions where they can be avoided
  • Reduce unnecessary memory allocations (e.g. avoid doing a map and a filter by writing the code in an imperative fashion)
  • Reduce layout trashing by using rAF and setTimeout
  • Perform cheaper checks first in conditional statements

See commit messages for more details.

Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c349d3b9344
perf: Reduce memory allocation, avoid regular expressions and layout trashing r=davidwalsh
Priority: -- → P3
Attachment #9101006 - Attachment description: perf: Reduce memory allocation, avoid regular expressions and layout trashing → Bug 1588637: Reduce memory allocation, avoid regular expressions and layout trashing r=davidwalsh
Status: UNCONFIRMED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Assignee: nobody → sorin.davidoi
Regressions: 1580323
You need to log in before you can comment on or make changes to this bug.