1589390 - Ensure Gecko metrics marked for geckoview_streaming are actually supported

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Chris H-C :chutten]

At present we support linear, exponential, and categorical histograms in GV Streaming, but not boolean or enumerated or count. We also don't support Event Telemetry.

We should error out of parsing if we encounter probes of unsupported types.

Comment 1

[Chris H-C :chutten]

Alessio, do you think we should error out on keyed types? We "support" them, but the keys are ignored.

Comment 2

[Chris H-C :chutten]

Attachment: Bug 1589390 - Fail the build when trying to add unsupported metrics to GV streaming

At present we support uint, bool, and string Scalars and linear,
exponential, and categorical Histograms. We do not support boolean,
enumerated, or count Histograms, or Events of any type.

Comment 3

[Alessio Placitelli [:Dexter]]

(In reply to Chris H-C :chutten from comment #1)

Alessio, do you think we should error out on keyed types? We "support" them, but the keys are ignored.

Yes, let's error out. I think otherwise users might assume data was collected as they expected :(

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef15949f8c12
Fail the build when trying to add unsupported metrics to GV streaming r=janerik

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ef15949f8c12