Closed Bug 1589390 Opened 2 months ago Closed Last month

Ensure Gecko metrics marked for geckoview_streaming are actually supported

Categories

(Toolkit :: Telemetry, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox71 --- wontfix
firefox72 --- fixed

People

(Reporter: chutten, Assigned: chutten)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

At present we support linear, exponential, and categorical histograms in GV Streaming, but not boolean or enumerated or count. We also don't support Event Telemetry.

We should error out of parsing if we encounter probes of unsupported types.

Alessio, do you think we should error out on keyed types? We "support" them, but the keys are ignored.

Flags: needinfo?(alessio.placitelli)

At present we support uint, bool, and string Scalars and linear,
exponential, and categorical Histograms. We do not support boolean,
enumerated, or count Histograms, or Events of any type.

(In reply to Chris H-C :chutten from comment #1)

Alessio, do you think we should error out on keyed types? We "support" them, but the keys are ignored.

Yes, let's error out. I think otherwise users might assume data was collected as they expected :(

Flags: needinfo?(alessio.placitelli)
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef15949f8c12
Fail the build when trying to add unsupported metrics to GV streaming r=janerik
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.