Closed Bug 1589588 Opened 6 months ago Closed 5 months ago

Thunderbird adjustments for Bug 1576946 - Implement <stack> using CSS Grid.

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 72.0

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(1 file, 4 obsolete files)

After bug 1576946 there are some small adjustments/cleanup to be done in Thunderbird.

Probably this. Will test later

Comment on attachment 9102046 [details] [diff] [review]
bug1589588_stack-grid-adjustments.patch

Review of attachment 9102046 [details] [diff] [review]:
-----------------------------------------------------------------

We've done a change a preferences.css you may want to port too.

Also you may want to audit places where you set the position attributes via JS as well.

::: mailnews/base/content/newmailalert.xul
@@ +30,5 @@
>          <folder-summary id="folderSummaryInfo" mousethrough="never"/>
>        </vbox>
>      </hbox>
>  
> +    <toolbarbutton id="closeButton" class="close-icon" onclick="closeAlert();"/>

right="0" will probably need to be replaced with `justify-self: right` (or `end` if you want RTL support) and top="0" with `align-self: start`.

See: https://groups.google.com/forum/#!topic/firefox-dev/NXrWtGs0CGk

Thanks Tim for the hint.
I tested with D46226 now. The preferences needed a .main-content too, otherwise one couldn't scroll down more than a bit on the preferences page.

Attachment #9105802 - Flags: review?(richard.marti)
Status: NEW → ASSIGNED

I found this too: https://searchfox.org/comm-central/source/mail/components/im/content/chat-conversation.js#236

There might be more, I'd recommend checking all the JS consumers (.top = and setAttribute("top", ...)), same with left/right/bottom/start/end.

Comment on attachment 9105802 [details] [diff] [review]
bug1589588_stack-grid-adjustments.patch

What's in this patch looks good. Please check Tim's comment 4 for more fixes.
Attachment #9105802 - Flags: review?(richard.marti) → review+

Fixed the case Tim found. I didn't find others.

Attachment #9102046 - Attachment is obsolete: true
Attachment #9105802 - Attachment is obsolete: true
Attachment #9105863 - Flags: review?(richard.marti)
Comment on attachment 9105863 [details] [diff] [review]
bug1589588_stack-grid-adjustments.patch

The conv-counter is still correctly positioned, thanks.
Attachment #9105863 - Flags: review?(richard.marti) → review+

Sorry for the late notice, but following last minute discussion with dholbert, we've decided to change the height: 100vh hack to a nicer min-height: 0 solution. You might want to port that over :)

Flags: needinfo?(mkmelin+mozilla)

Adjusted. Thanks Tim!

Attachment #9105863 - Attachment is obsolete: true
Flags: needinfo?(mkmelin+mozilla)
Attachment #9108238 - Flags: review+
Attachment #9108238 - Attachment is obsolete: true

This should do it.

Attachment #9108339 - Flags: review+

This should land before the daily build starts.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/96490ef9899a
Adjustments to <stack> after bug 1576946. r=Paenglab DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED

Late notice.

Target Milestone: --- → Thunderbird 72.0
You need to log in before you can comment on or make changes to this bug.