1589588 - Thunderbird adjustments for Bug 1576946 - Implement <stack> using CSS Grid.

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Magnus Melin [:mkmelin]]

After bug 1576946 there are some small adjustments/cleanup to be done in Thunderbird.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1589588_stack-grid-adjustments.patch

Probably this. Will test later

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 9102046 [details] [diff] [review]
bug1589588_stack-grid-adjustments.patch

Review of attachment 9102046 [details] [diff] [review]:
-----------------------------------------------------------------

We've done a change a preferences.css you may want to port too.

Also you may want to audit places where you set the position attributes via JS as well.

::: mailnews/base/content/newmailalert.xul
@@ +30,5 @@
>          <folder-summary id="folderSummaryInfo" mousethrough="never"/>
>        </vbox>
>      </hbox>
>  
> +    <toolbarbutton id="closeButton" class="close-icon" onclick="closeAlert();"/>

right="0" will probably need to be replaced with `justify-self: right` (or `end` if you want RTL support) and top="0" with `align-self: start`.

See: https://groups.google.com/forum/#!topic/firefox-dev/NXrWtGs0CGk

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: bug1589588_stack-grid-adjustments.patch

Thanks Tim for the hint.
I tested with D46226 now. The preferences needed a .main-content too, otherwise one couldn't scroll down more than a bit on the preferences page.

Comment 4

[Tim Nguyen :ntim]

I found this too: https://searchfox.org/comm-central/source/mail/components/im/content/chat-conversation.js#236

There might be more, I'd recommend checking all the JS consumers (.top = and setAttribute("top", ...)), same with left/right/bottom/start/end.

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9105802 [details] [diff] [review]
bug1589588_stack-grid-adjustments.patch

What's in this patch looks good. Please check Tim's comment 4 for more fixes.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: bug1589588_stack-grid-adjustments.patch

Fixed the case Tim found. I didn't find others.

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9105863 [details] [diff] [review]
bug1589588_stack-grid-adjustments.patch

The conv-counter is still correctly positioned, thanks.

Comment 8

[Tim Nguyen :ntim]

Sorry for the late notice, but following last minute discussion with dholbert, we've decided to change the height: 100vh hack to a nicer min-height: 0 solution. You might want to port that over :)

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: bug1589588_stack-grid-adjustments.patch

Adjusted. Thanks Tim!

Comment 10

[Tim Nguyen :ntim]

Note that we set min-height: 0; on the stack and the stack children:
https://hg.mozilla.org/integration/autoland/rev/7477b284a8a3#l5.12
https://hg.mozilla.org/integration/autoland/rev/7477b284a8a3#l3.13

Comment 11

[Magnus Melin [:mkmelin]]

Attachment: bug1589588_stack-grid-adjustments.patch

This should do it.

Comment 12

[Richard Marti (:Paenglab)]

This should land before the daily build starts.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/96490ef9899a
Adjustments to <stack> after bug 1576946. r=Paenglab DONTBUILD

Comment 14

[Jorg K (CEST = GMT+2)]

Late notice.