Closed Bug 1589592 Opened Last month Closed Last month

Console editor looks broken on RTL languages

Categories

(DevTools :: Console, defect, P1)

defect

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(3 files)

  • The resizer is buggy
  • The "Run" button icon is misplaced

Since we want the button to be placed on the right side
in RTL languages and we don't have logical properties
on background-position yet, we display the icon in
a :before pseudo element which will adapt for both LTR
and RTL languages. The icon is then mirrored in RTL.

Depends on D49717

When starting to resize, we store the direction of the
controlled element in the state.
When resizing, we check the current element direction
to set the appropriate width to the controlled element.
A test is added to ensure the resizer works as expected
in RTL languages elements.

Depends on D49718

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e87688a24f47
Fix Console Editor styling in RTL languages. r=Honza.
https://hg.mozilla.org/integration/autoland/rev/81c1d93d635a
Fix console editor Run button icon in RTL. r=Honza.
https://hg.mozilla.org/integration/autoland/rev/3517b23f7cc4
Fix GridElementWidthResizer in RTL languages. r=Honza.
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Regressions: 1589867
See Also: → 1590212
You need to log in before you can comment on or make changes to this bug.