1589592 - Console editor looks broken on RTL languages

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

• The resizer is buggy
• The "Run" button icon is misplaced

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1589592 - Fix Console Editor styling in RTL languages. r=Honza.

Depends on D45302

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1589592 - Fix console editor Run button icon in RTL. r=Honza.

Since we want the button to be placed on the right side
in RTL languages and we don't have logical properties
on background-position yet, we display the icon in
a :before pseudo element which will adapt for both LTR
and RTL languages. The icon is then mirrored in RTL.

Depends on D49717

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1589592 - Fix GridElementWidthResizer in RTL languages. r=Honza.

When starting to resize, we store the direction of the
controlled element in the state.
When resizing, we check the current element direction
to set the appropriate width to the controlled element.
A test is added to ensure the resizer works as expected
in RTL languages elements.

Depends on D49718

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e87688a24f47
Fix Console Editor styling in RTL languages. r=Honza.
https://hg.mozilla.org/integration/autoland/rev/81c1d93d635a
Fix console editor Run button icon in RTL. r=Honza.
https://hg.mozilla.org/integration/autoland/rev/3517b23f7cc4
Fix GridElementWidthResizer in RTL languages. r=Honza.

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e87688a24f47
https://hg.mozilla.org/mozilla-central/rev/81c1d93d635a
https://hg.mozilla.org/mozilla-central/rev/3517b23f7cc4