Closed Bug 1589848 Opened 5 years ago Closed 5 years ago

Perma late beta browser/components/preferences/in-content/tests/browser_extension_controlled.js | uncaught exception - TypeError: document.getElementById(...).selectedItem is null when Gecko 71 becomes late Beta in November 2019

Categories

(Firefox :: Settings UI, defect, P1)

Product:
Firefox
Component:
Settings UI
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 72
Iteration:
72.1 - Oct 21 - Nov 3
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- unaffected
firefox71 + fixed
firefox72 --- verified

People

(Reporter: bogdan_tara, Assigned: standard8)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1589848 - Don't try and update the separate private engine selector in preferences when the UI isn't shown. r?mak,mikedeboer
47 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272029540&repo=try&lineNumber=2619

https://queue.taskcluster.net/v1/task/DbqnFN6ZRmOs_judqlMT2A/runs/0/artifacts/public/logs/live_backing.log

[task 2019-10-19T12:13:20.921Z] 12:13:20 INFO - TEST-START | browser/components/preferences/in-content/tests/browser_extension_controlled.js
[task 2019-10-19T12:13:28.877Z] 12:13:28 INFO - TEST-INFO | started process screentopng
[task 2019-10-19T12:13:29.521Z] 12:13:29 INFO - TEST-INFO | screentopng: exit 0
[task 2019-10-19T12:13:29.522Z] 12:13:29 INFO - Buffered messages logged at 12:13:20
[task 2019-10-19T12:13:29.523Z] 12:13:29 INFO - Entering test bound testExtensionControlledHomepage
[task 2019-10-19T12:13:29.524Z] 12:13:29 INFO - Buffered messages logged at 12:13:21
[task 2019-10-19T12:13:29.525Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | #home should be in the URI for about:preferences -
[task 2019-10-19T12:13:29.526Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | homepage is empty by default -
[task 2019-10-19T12:13:29.527Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The homepage menulist is enabled -
[task 2019-10-19T12:13:29.528Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The custom settings element is hidden -
[task 2019-10-19T12:13:29.528Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is hidden -
[task 2019-10-19T12:13:29.530Z] 12:13:29 INFO - Buffered messages logged at 12:13:22
[task 2019-10-19T12:13:29.531Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | homepage is set by extension -
[task 2019-10-19T12:13:29.532Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The user is notified that an extension is controlling the homepage - {"args":{"name":"set_homepage"},"id":"extension-controlled-homepage-override"} deepEqual {"id":"extension-controlled-homepage-override","args":{"name":"set_homepage"}} -
[task 2019-10-19T12:13:29.533Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is hidden -
[task 2019-10-19T12:13:29.534Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The homepage input is disabled -
[task 2019-10-19T12:13:29.537Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The user is notified of how to enable the extension again -
[task 2019-10-19T12:13:29.538Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | homepage is set back to default -
[task 2019-10-19T12:13:29.539Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The homepage menulist is enabled -
[task 2019-10-19T12:13:29.540Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is hidden -
[task 2019-10-19T12:13:29.541Z] 12:13:29 INFO - Leaving test bound testExtensionControlledHomepage
[task 2019-10-19T12:13:29.542Z] 12:13:29 INFO - Entering test bound testPrefLockedHomepage
[task 2019-10-19T12:13:29.543Z] 12:13:29 INFO - Buffered messages logged at 12:13:23
[task 2019-10-19T12:13:29.544Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | #home should be in the URI for about:preferences -
...
[task 2019-10-19T12:13:29.582Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled message is hidden when unlocked with no extension -
[task 2019-10-19T12:13:29.582Z] 12:13:29 INFO - Leaving test bound testPrefLockedHomepage
[task 2019-10-19T12:13:29.583Z] 12:13:29 INFO - Entering test bound testExtensionControlledNewTab
[task 2019-10-19T12:13:29.583Z] 12:13:29 INFO - Buffered messages logged at 12:13:24
[task 2019-10-19T12:13:29.583Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | #home should be in the URI for about:preferences -
[task 2019-10-19T12:13:29.583Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | new tab is not set -
[task 2019-10-19T12:13:29.585Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is hidden -
[task 2019-10-19T12:13:29.585Z] 12:13:29 INFO - Buffered messages logged at 12:13:25
[task 2019-10-19T12:13:29.586Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | new tab url is set by extension -
[task 2019-10-19T12:13:29.586Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The user is notified that an extension is controlling the new tab page - {"args":{"name":"set_newtab"},"id":"extension-controlled-new-tab-url"} deepEqual {"id":"extension-controlled-new-tab-url","args":{"name":"set_newtab"}} -
[task 2019-10-19T12:13:29.586Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is hidden -
[task 2019-10-19T12:13:29.588Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The user is notified of how to enable the extension again -
[task 2019-10-19T12:13:29.588Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | new tab page is set back to default -
[task 2019-10-19T12:13:29.588Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is shown -
[task 2019-10-19T12:13:29.589Z] 12:13:29 INFO - Leaving test bound testExtensionControlledNewTab
[task 2019-10-19T12:13:29.590Z] 12:13:29 INFO - Entering test bound testExtensionControlledWebNotificationsPermission
[task 2019-10-19T12:13:29.591Z] 12:13:29 INFO - Buffered messages logged at 12:13:26
[task 2019-10-19T12:13:29.591Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | Check the proper URL is loaded -
[task 2019-10-19T12:13:29.591Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | Element should not be null, when checking visibility -
[task 2019-10-19T12:13:29.592Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | Overlay is visible -
[task 2019-10-19T12:13:29.592Z] 12:13:29 INFO - found chrome://browser/skin/preferences/preferences.css
[task 2019-10-19T12:13:29.596Z] 12:13:29 INFO - found chrome://global/skin/in-content/common.css
[task 2019-10-19T12:13:29.597Z] 12:13:29 INFO - found chrome://browser/skin/preferences/in-content/preferences.css
[task 2019-10-19T12:13:29.598Z] 12:13:29 INFO - found chrome://browser/skin/preferences/in-content/dialog.css
[task 2019-10-19T12:13:29.598Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | All expectedStyleSheetURLs should have been found -
[task 2019-10-19T12:13:29.598Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | Extension content is initially hidden -
[task 2019-10-19T12:13:29.599Z] 12:13:29 INFO - Extension loaded
[task 2019-10-19T12:13:29.601Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The user is notified that an extension is controlling the web notifications permission - {"args":{"name":"TestExtension"},"id":"extension-controlled-web-notifications"} deepEqual {"id":"extension-controlled-web-notifications","args":{"name":"TestExtension"}} -
[task 2019-10-19T12:13:29.601Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is not hidden -
[task 2019-10-19T12:13:29.603Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The user is notified of how to enable the extension again -
[task 2019-10-19T12:13:29.603Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is now hidden -
[task 2019-10-19T12:13:29.604Z] 12:13:29 INFO - Leaving test bound testExtensionControlledWebNotificationsPermission
[task 2019-10-19T12:13:29.604Z] 12:13:29 INFO - Entering test bound testExtensionControlledDefaultSearch
[task 2019-10-19T12:13:29.604Z] 12:13:29 INFO - Buffered messages logged at 12:13:28
[task 2019-10-19T12:13:29.606Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | #search should be in the URI for about:preferences -
[task 2019-10-19T12:13:29.606Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is hidden -
[task 2019-10-19T12:13:29.606Z] 12:13:29 INFO - Extension loaded
[task 2019-10-19T12:13:29.607Z] 12:13:29 INFO - Buffered messages finished
[task 2019-10-19T12:13:29.608Z] 12:13:29 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_extension_controlled.js | uncaught exception - TypeError: document.getElementById(...).selectedItem is null at observe@chrome://browser/content/preferences/in-content/search.js:433:43
[task 2019-10-19T12:13:29.608Z] 12:13:29 INFO - notifyAction@resource://gre/modules/SearchUtils.jsm:80:20
[task 2019-10-19T12:13:29.609Z] 12:13:29 INFO - _setEngineDefault@resource://gre/modules/SearchService.jsm:2927:19
[task 2019-10-19T12:13:29.609Z] 12:13:29 INFO - set defaultEngine@resource://gre/modules/SearchService.jsm:2939:10
[task 2019-10-19T12:13:29.609Z] 12:13:29 INFO - setDefault@resource://gre/modules/SearchService.jsm:2957:5
[task 2019-10-19T12:13:29.609Z] 12:13:29 INFO -
[task 2019-10-19T12:13:29.609Z] 12:13:29 INFO - Stack trace:
[task 2019-10-19T12:13:29.610Z] 12:13:29 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1667
[task 2019-10-19T12:13:29.610Z] 12:13:29 INFO - resource://gre/modules/SearchUtils.jsm:notifyAction:80
[task 2019-10-19T12:13:29.610Z] 12:13:29 INFO - resource://gre/modules/SearchService.jsm:_setEngineDefault:2927
[task 2019-10-19T12:13:29.610Z] 12:13:29 INFO - resource://gre/modules/SearchService.jsm:set defaultEngine:2939
[task 2019-10-19T12:13:29.611Z] 12:13:29 INFO - resource://gre/modules/SearchService.jsm:setDefault:2957
[task 2019-10-19T12:13:29.611Z] 12:13:29 INFO - GECKO(2259) | JavaScript error: chrome://browser/content/preferences/in-content/search.js, line 433: TypeError: document.getElementById(...).selectedItem is null
[task 2019-10-19T12:13:29.611Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | Search provider extension should be running - "running" == "running" -
[task 2019-10-19T12:13:29.612Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | Extension ID of search provider should be set - "@set_default_search" == true -
[task 2019-10-19T12:13:29.613Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The addon has the expected version. -
[task 2019-10-19T12:13:29.614Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The default engine has changed. -
[task 2019-10-19T12:13:29.614Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The user is notified that an extension is controlling the default search engine - {"args":{"name":"set_default_search"},"id":"extension-controlled-default-search"} deepEqual {"id":"extension-controlled-default-search","args":{"name":"set_default_search"}} -
[task 2019-10-19T12:13:29.614Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is shown -
[task 2019-10-19T12:13:29.616Z] 12:13:29 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-10-19T12:13:29.616Z] 12:13:29 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_extension_controlled.js | uncaught exception - TypeError: document.getElementById(...).selectedItem is null at observe@chrome://browser/content/preferences/in-content/search.js:433:43
[task 2019-10-19T12:13:29.617Z] 12:13:29 INFO - notifyAction@resource://gre/modules/SearchUtils.jsm:80:20
[task 2019-10-19T12:13:29.617Z] 12:13:29 INFO - _setEngineDefault@resource://gre/modules/SearchService.jsm:2927:19
[task 2019-10-19T12:13:29.617Z] 12:13:29 INFO - set defaultEngine@resource://gre/modules/SearchService.jsm:2939:10
[task 2019-10-19T12:13:29.617Z] 12:13:29 INFO - setDefault@resource://gre/modules/SearchService.jsm:2957:5
[task 2019-10-19T12:13:29.618Z] 12:13:29 INFO -
[task 2019-10-19T12:13:29.618Z] 12:13:29 INFO - Stack trace:
[task 2019-10-19T12:13:29.618Z] 12:13:29 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1667
[task 2019-10-19T12:13:29.618Z] 12:13:29 INFO - resource://gre/modules/SearchUtils.jsm:notifyAction:80
[task 2019-10-19T12:13:29.619Z] 12:13:29 INFO - resource://gre/modules/SearchService.jsm:_setEngineDefault:2927
[task 2019-10-19T12:13:29.619Z] 12:13:29 INFO - resource://gre/modules/SearchService.jsm:set defaultEngine:2939
[task 2019-10-19T12:13:29.619Z] 12:13:29 INFO - resource://gre/modules/SearchService.jsm:setDefault:2957
[task 2019-10-19T12:13:29.620Z] 12:13:29 INFO - GECKO(2259) | JavaScript error: chrome://browser/content/preferences/in-content/search.js, line 433: TypeError: document.getElementById(...).selectedItem is null
[task 2019-10-19T12:13:29.621Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | default search engine is set back to default -
[task 2019-10-19T12:13:29.621Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is hidden -
[task 2019-10-19T12:13:29.622Z] 12:13:29 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-10-19T12:13:29.623Z] 12:13:29 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_extension_controlled.js | uncaught exception - TypeError: document.getElementById(...).selectedItem is null at observe@chrome://browser/content/preferences/in-content/search.js:433:43
[task 2019-10-19T12:13:29.624Z] 12:13:29 INFO - notifyAction@resource://gre/modules/SearchUtils.jsm:80:20
[task 2019-10-19T12:13:29.624Z] 12:13:29 INFO - _setEngineDefault@resource://gre/modules/SearchService.jsm:2927:19
[task 2019-10-19T12:13:29.624Z] 12:13:29 INFO - set defaultEngine@resource://gre/modules/SearchService.jsm:2939:10
[task 2019-10-19T12:13:29.624Z] 12:13:29 INFO - setDefault@resource://gre/modules/SearchService.jsm:2957:5
[task 2019-10-19T12:13:29.625Z] 12:13:29 INFO -
[task 2019-10-19T12:13:29.625Z] 12:13:29 INFO - Stack trace:
[task 2019-10-19T12:13:29.625Z] 12:13:29 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1667
[task 2019-10-19T12:13:29.625Z] 12:13:29 INFO - resource://gre/modules/SearchUtils.jsm:notifyAction:80
[task 2019-10-19T12:13:29.626Z] 12:13:29 INFO - resource://gre/modules/SearchService.jsm:_setEngineDefault:2927
[task 2019-10-19T12:13:29.626Z] 12:13:29 INFO - resource://gre/modules/SearchService.jsm:set defaultEngine:2939
[task 2019-10-19T12:13:29.626Z] 12:13:29 INFO - resource://gre/modules/SearchService.jsm:setDefault:2957
[task 2019-10-19T12:13:29.626Z] 12:13:29 INFO - GECKO(2259) | JavaScript error: chrome://browser/content/preferences/in-content/search.js, line 433: TypeError: document.getElementById(...).selectedItem is null
[task 2019-10-19T12:13:29.627Z] 12:13:29 INFO - Console message: [JavaScript Error: "TypeError: document.getElementById(...).selectedItem is null" {file: "chrome://browser/content/preferences/in-content/search.js" line: 433}]
[task 2019-10-19T12:13:29.627Z] 12:13:29 INFO - observe@chrome://browser/content/preferences/in-content/search.js:433:43
[task 2019-10-19T12:13:29.627Z] 12:13:29 INFO - notifyAction@resource://gre/modules/SearchUtils.jsm:80:20
[task 2019-10-19T12:13:29.628Z] 12:13:29 INFO - _setEngineDefault@resource://gre/modules/SearchService.jsm:2927:19
[task 2019-10-19T12:13:29.628Z] 12:13:29 INFO - set defaultEngine@resource://gre/modules/SearchService.jsm:2939:10
[task 2019-10-19T12:13:29.628Z] 12:13:29 INFO - setDefault@resource://gre/modules/SearchService.jsm:2957:5
[task 2019-10-19T12:13:29.628Z] 12:13:29 INFO -
[task 2019-10-19T12:13:29.632Z] 12:13:29 INFO - Console message: [JavaScript Error: "TypeError: document.getElementById(...).selectedItem is null" {file: "chrome://browser/content/preferences/in-content/search.js" line: 433}]
[task 2019-10-19T12:13:29.633Z] 12:13:29 INFO - observe@chrome://browser/content/preferences/in-content/search.js:433:43
[task 2019-10-19T12:13:29.633Z] 12:13:29 INFO - notifyAction@resource://gre/modules/SearchUtils.jsm:80:20
[task 2019-10-19T12:13:29.633Z] 12:13:29 INFO - _setEngineDefault@resource://gre/modules/SearchService.jsm:2927:19
[task 2019-10-19T12:13:29.634Z] 12:13:29 INFO - set defaultEngine@resource://gre/modules/SearchService.jsm:2939:10
[task 2019-10-19T12:13:29.634Z] 12:13:29 INFO - setDefault@resource://gre/modules/SearchService.jsm:2957:5
[task 2019-10-19T12:13:29.635Z] 12:13:29 INFO -
[task 2019-10-19T12:13:29.635Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | default search engine is set back to extension -
[task 2019-10-19T12:13:29.636Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is still hidden -
[task 2019-10-19T12:13:29.637Z] 12:13:29 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-10-19T12:13:29.638Z] 12:13:29 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_extension_controlled.js | uncaught exception - TypeError: document.getElementById(...).selectedItem is null at observe@chrome://browser/content/preferences/in-content/search.js:433:43
[task 2019-10-19T12:13:29.639Z] 12:13:29 INFO - notifyAction@resource://gre/modules/SearchUtils.jsm:80:20
[task 2019-10-19T12:13:29.640Z] 12:13:29 INFO - _setEngineDefault@resource://gre/modules/SearchService.jsm:2927:19
[task 2019-10-19T12:13:29.641Z] 12:13:29 INFO - set defaultEngine@resource://gre/modules/SearchService.jsm:2939:10
[task 2019-10-19T12:13:29.642Z] 12:13:29 INFO - setDefault@resource://gre/modules/SearchService.jsm:2957:5
[task 2019-10-19T12:13:29.642Z] 12:13:29 INFO -
[task 2019-10-19T12:13:29.643Z] 12:13:29 INFO - Stack trace:
[task 2019-10-19T12:13:29.644Z] 12:13:29 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1667
[task 2019-10-19T12:13:29.645Z] 12:13:29 INFO - resource://gre/modules/SearchUtils.jsm:notifyAction:80
[task 2019-10-19T12:13:29.646Z] 12:13:29 INFO - resource://gre/modules/SearchService.jsm:_setEngineDefault:2927
[task 2019-10-19T12:13:29.647Z] 12:13:29 INFO - resource://gre/modules/SearchService.jsm:set defaultEngine:2939
[task 2019-10-19T12:13:29.647Z] 12:13:29 INFO - resource://gre/modules/SearchService.jsm:setDefault:2957
[task 2019-10-19T12:13:29.648Z] 12:13:29 INFO - GECKO(2259) | JavaScript error: chrome://browser/content/preferences/in-content/search.js, line 433: TypeError: document.getElementById(...).selectedItem is null
[task 2019-10-19T12:13:29.649Z] 12:13:29 INFO - Extension loaded
[task 2019-10-19T12:13:29.651Z] 12:13:29 INFO - Console message: [JavaScript Error: "TypeError: document.getElementById(...).selectedItem is null" {file: "chrome://browser/content/preferences/in-content/search.js" line: 433}]
[task 2019-10-19T12:13:29.652Z] 12:13:29 INFO - observe@chrome://browser/content/preferences/in-content/search.js:433:43
[task 2019-10-19T12:13:29.653Z] 12:13:29 INFO - notifyAction@resource://gre/modules/SearchUtils.jsm:80:20
[task 2019-10-19T12:13:29.654Z] 12:13:29 INFO - _setEngineDefault@resource://gre/modules/SearchService.jsm:2927:19
[task 2019-10-19T12:13:29.655Z] 12:13:29 INFO - set defaultEngine@resource://gre/modules/SearchService.jsm:2939:10
[task 2019-10-19T12:13:29.655Z] 12:13:29 INFO - setDefault@resource://gre/modules/SearchService.jsm:2957:5
[task 2019-10-19T12:13:29.656Z] 12:13:29 INFO -
[task 2019-10-19T12:13:29.657Z] 12:13:29 INFO - Console message: [JavaScript Error: "TypeError: document.getElementById(...).selectedItem is null" {file: "chrome://browser/content/preferences/in-content/search.js" line: 433}]
[task 2019-10-19T12:13:29.658Z] 12:13:29 INFO - observe@chrome://browser/content/preferences/in-content/search.js:433:43
[task 2019-10-19T12:13:29.659Z] 12:13:29 INFO - notifyAction@resource://gre/modules/SearchUtils.jsm:80:20
[task 2019-10-19T12:13:29.660Z] 12:13:29 INFO - _setEngineDefault@resource://gre/modules/SearchService.jsm:2927:19
[task 2019-10-19T12:13:29.661Z] 12:13:29 INFO - set defaultEngine@resource://gre/modules/SearchService.jsm:2939:10
[task 2019-10-19T12:13:29.662Z] 12:13:29 INFO - setDefault@resource://gre/modules/SearchService.jsm:2957:5
[task 2019-10-19T12:13:29.662Z] 12:13:29 INFO -
[task 2019-10-19T12:13:29.663Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | Search provider extension should be running - "running" == "running" -
[task 2019-10-19T12:13:29.664Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | Extension ID of search provider should be set - "@set_default_search" == true -
[task 2019-10-19T12:13:29.665Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The updated addon has the expected version -
[task 2019-10-19T12:13:29.666Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | The extension controlled row is hidden after update -
[task 2019-10-19T12:13:29.667Z] 12:13:29 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_extension_controlled.js | default search engine is still the initial engine after update -
[task 2019-10-19T12:13:29.688Z] 12:13:29 INFO - GECKO(2259) | 1571487209681 addons.xpi WARN Attempted to remove @set_default_search from app-profile but it was already gone
[task 2019-10-19T12:13:29.697Z] 12:13:29 INFO - Console message: 1571487209681 addons.xpi WARN Attempted to remove @set_default_search from app-profile but it was already gone
[task 2019-10-19T12:13:29.738Z] 12:13:29 INFO - Leaving test bound testExtensionControlledDefaultSearch

I think this could be caused by bug 1588785.

standard8 could you, please, take a look?

Flags: needinfo?(standard8)

le: this showed up on the late beta simulation, so far.

status-firefox67: --- → unaffected
status-firefox68: --- → unaffected
status-firefox-esr60: --- → unaffected
status-firefox-esr68: --- → unaffected
Regressed by: 1588785
Summary: Perma browser/components/preferences/in-content/tests/browser_extension_controlled.js | uncaught exception - TypeError: document.getElementById(...).selectedItem is null at observe@chrome://*/search.js:433:43 when Gecko 71 merges to Beta on 2019-10-14 → Perma late beta browser/components/preferences/in-content/tests/browser_extension_controlled.js | uncaught exception - TypeError: document.getElementById(...).selectedItem is null when Gecko 71 becomes late Beta in November 2019

Probably something simple and test-only that I'd missed.

Assignee: nobody → standard8
Blocks: private-search
Status: NEW → ASSIGNED
Iteration: --- → 72.1 - Oct 21 - Nov 3
Points: --- → 1
Flags: needinfo?(standard8)
Priority: -- → P1
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/53362f65d1b6 Don't try and update the separate private engine selector in preferences when the UI isn't shown. r=mak

https://hg.mozilla.org/mozilla-central/rev/53362f65d1b6

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Comment on attachment 9102908 [details]
Bug 1589848 - Don't try and update the separate private engine selector in preferences when the UI isn't shown. r?mak,mikedeboer

Beta/Release Uplift Approval Request

  • User impact if declined: None, at worst this would generate a warning. However, uplift is required to fix a test issue if the separate private browsing is turned off for any reason.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small change just restricted to the search part of preferences
  • String changes made/needed: None
Attachment #9102908 - Flags: approval-mozilla-beta?

Comment on attachment 9102908 [details]
Bug 1589848 - Don't try and update the separate private engine selector in preferences when the UI isn't shown. r?mak,mikedeboer

Low risk, has tests, uplift approved for 71 beta 4, thanks.

Attachment #9102908 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: