1589982 - GeckoView test will fail when DocumentChannel is enabled.

Status: RESOLVED WORKSFORME

(GeckoView :: General, defect, P3)

Description

[Jean-Yves Avenard [:jya]]

See https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272011843&repo=try&lineNumber=2546

The GV unit test expects a set amount of events to occur.

However, when using DocumentChannel nsIWebProgressListener will emit an extra event when redirecting to the real channel.

Either the tests need to be amended, or change the java binding so that redirects shouldn't be forwarded.

Comment 1

[Matt Woodrow (:mattwoodrow)]

I think this code [1] should be checking for STATE_IS_DOCUMENT as well as STATE_START/STOP flags, so that we only forward the actual document start/stop, and not intermediate ones for redirects.

[1] https://searchfox.org/mozilla-central/rev/d7537a9cd2974efa45141d974e5fc7c727f1a78f/mobile/android/modules/geckoview/GeckoViewProgress.jsm#244

Comment 2

[Chris Peterson [:cpeterson]]

P3 Fission bug

Comment 3

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 4

[Chris Peterson [:cpeterson]]

Matt, do you need to fix this GeckoView test in 72 if you plan to ship DocumentChannel for non-Fission?

Comment 5

[Matt Woodrow (:mattwoodrow)]

No, DocumentChannel is only enabled for desktop currently, so it won't block anything until we want to support GV.

Comment 6

[Chris Peterson [:cpeterson]]

GV bugs don't need to block Fission MVP.

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

We have DocumentChannel enabled already, so this isn't a problem anymore.