Closed Bug 1590119 Opened 3 months ago Closed 3 months ago

NetMonitor blocking - manually added, disabled patterns are still blocking requests

Categories

(DevTools :: Netmonitor, defect, P2, critical)

71 Branch
Desktop
All
defect

Tracking

(firefox70 unaffected, firefox71 verified, firefox72 verified)

VERIFIED FIXED
Firefox 72
Tracking Status
firefox70 --- unaffected
firefox71 --- verified
firefox72 --- verified

People

(Reporter: cfogel, Assigned: davidwalsh)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Affected versions

  • 71.0a1 (2019-10-21)

Affected platforms

  • Windows 10, macOS 10.13, Ubuntu 16.04;

Steps to reproduce
devtools.netmonitor.features.requestBlocking - pref set on true

  1. Launch Firefox, access https://www.wikipedia.org/
  2. enable the Netmonitor - Request Blocking section;
  3. In the blocking section add to block: wikipedia
  4. Refresh the page;
  5. Right click on the blocked request;
  6. Click on the Unblock option;
  7. Refresh the page.

Expected result

  • request is not blocked;
  • filter is still in list but checkbox empty;

Actual result

  • request remains blocked;
  • filter appears to be toggled off(checkbox) but remains active;

Regression range

  • most likely not a regression, only visible after implementation of bug 1580728;

Additional notes

  • added recording with the issue;
  • manually toggling the filter has the desired effect;

Thanks for the report I can reproduce the issue on my machine (Win10, Nightly)
Honza

Blocks: 1580526
Has STR: --- → yes
Priority: -- → P2

David, can you please look at this.
Honza

Flags: needinfo?(davidwalsh83)

David, don't forget to assign bugs to yourself.

Honza

Assignee: nobody → dwalsh
Status: NEW → ASSIGNED

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c8d02b4dca0
Ensure matched blocking URLs are sent to server r=Honza
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72

Fix verified with 72.0a1 (2019-10-22).
71.0b3 still affected.

clearing ni

Flags: needinfo?(davidwalsh83)

Comment on attachment 9103025 [details]
Bug 1590119 - Ensure matched blocking URLs are sent to server r=Honza

Beta/Release Uplift Approval Request

  • User impact if declined: A key interaction in the new request blocking feature will be broken
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Verified by QA in Nightly. The fix is extremely simple.
  • String changes made/needed:
Attachment #9103025 - Flags: approval-mozilla-beta?

Comment on attachment 9103025 [details]
Bug 1590119 - Ensure matched blocking URLs are sent to server r=Honza

Minimal patch fixing a visible bug in a new devtools feature, verified as fixed on Nightly by QA, uplift approved for 71 beta 4, thanks.

Attachment #9103025 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Verified with 71.0b4 on macOS 10.13, Windows 10, Ubuntu 16.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.