1590185 - Add a paged mode layout to layout debugger

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

This bug is to add a paged mode layout in layout debugger like what we have in "reftest-paged" reftests. The print setup is in setupPrintMode() in reftest-content.js.

When interactively debugging fragmentation in rr, this might be useful by using a fragmention environment closer to real printing setup rather in multicol on certain cases.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1590185 Part 1 - Remove obsolete member variables in nsLayoutDebuggingTools.

Bug 1566215 Part 3 moved these features to layoutdebug.js.
https://hg.mozilla.org/mozilla-central/rev/f84c119572a1f4d8b20ac05c0bd8cefe4fe70fef

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1590185 Part 2 - Support paged mode layout in layout debugger.

This patch adds a menu item in "Toggle" -> "Paged Mode". If the item is
toggled, after finishing loading the document, the document will be
forced into paged mode.

The print settings in nsLayoutDebuggingTools::SetPagedMode() are
similar to setupPrintMode() in reftest-content.js.

Remove the hack in nsDocumentViewer::InitInternal() because we don't
want to set a new document when mIsPageMode = false.

Depends on D49992

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1590185 Part 3 - Add --paged command line argument to layout debugger.

Depends on D49993

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d848235872b1
Part 1 - Remove obsolete member variables in nsLayoutDebuggingTools. r=heycam
https://hg.mozilla.org/integration/autoland/rev/30f66e8e2c19
Part 2 - Support paged mode layout in layout debugger. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/3825f76612d8
Part 3 - Add --paged command line argument to layout debugger. r=heycam

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d848235872b1
https://hg.mozilla.org/mozilla-central/rev/30f66e8e2c19
https://hg.mozilla.org/mozilla-central/rev/3825f76612d8

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d848235872b1
https://hg.mozilla.org/integration/mozilla-inbound/rev/30f66e8e2c19
https://hg.mozilla.org/integration/mozilla-inbound/rev/3825f76612d8