1590246 - Update audioipc to 8af8083a

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, task, P2)

Description

[Matthew Gregan [:kinetik]]

Update audioipc to 8f2a9e0a from upstream.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Bug 1590246 - Update audioipc to 8af8083a. r?chunmin

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Bug 1590246 - Vendor Rust. r?chunmin

Depends on D50000

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37e879bff967
Update audioipc to 8f2a9e0a.  r=chunmin
https://hg.mozilla.org/integration/autoland/rev/586eef699017
Vendor Rust.  r=chunmin

Comment 4

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1590246) for causing windows bustages on audioipc-client.

Backout link: https://hg.mozilla.org/integration/autoland/rev/e528f32390b25793f780b90f05e943dd3c02065d

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=272297981&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&tochange=e528f32390b25793f780b90f05e943dd3c02065d&fromchange=586eef6990173049ef68dcecc9fe7eed3785b071&searchStr=win%2Cbuild&group_state=expanded

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272297954&repo=autoland&lineNumber=22072
[task 2019-10-22T00:28:05.969Z] 00:28:05 ERROR - error[E0277]: *mut std::ffi::c_void cannot be shared between threads safely
[task 2019-10-22T00:28:05.969Z] 00:28:05 INFO - --> media\audioipc\client\src\context.rs:228:14
[task 2019-10-22T00:28:05.969Z] 00:28:05 INFO - |
[task 2019-10-22T00:28:05.970Z] 00:28:05 INFO - 228 | .after_start(move || promote_and_register_thread(&rpc2, params.thread_create_callback))
[task 2019-10-22T00:28:05.970Z] 00:28:05 INFO - | ^^^^^^^^^^^ *mut std::ffi::c_void cannot be shared between threads safely
[task 2019-10-22T00:28:05.970Z] 00:28:05 INFO - |
[task 2019-10-22T00:28:05.970Z] 00:28:05 INFO - = help: within [closure@media\audioipc\client\src\context.rs:228:26: 228:99 rpc2:audioipc::rpc::client::proxy::ClientProxy<audioipc::messages::ServerMessage, audioipc::messages::ClientMessage>, params:AudioIpcInitParams], the trait std::marker::Sync is not implemented for *mut std::ffi::c_void
[task 2019-10-22T00:28:05.970Z] 00:28:05 INFO - = note: required because it appears within the type AudioIpcInitParams
[task 2019-10-22T00:28:05.970Z] 00:28:05 INFO - = note: required because it appears within the type [closure@media\audioipc\client\src\context.rs:228:26: 228:99 rpc2:audioipc::rpc::client::proxy::ClientProxy<audioipc::messages::ServerMessage, audioipc::messages::ClientMessage>, params:AudioIpcInitParams]
[task 2019-10-22T00:28:05.970Z] 00:28:05 INFO - error: aborting due to 2 previous errors
[task 2019-10-22T00:28:05.970Z] 00:28:05 INFO - For more information about this error, try rustc --explain E0277.
[task 2019-10-22T00:28:05.970Z] 00:28:05 ERROR - error: Could not compile audioipc-client.
[task 2019-10-22T00:28:05.970Z] 00:28:05 INFO - Caused by:
[task 2019-10-22T00:28:05.970Z] 00:28:05 INFO - process didn't exit successfully: set CARGO_MANIFEST_DIR='Z:\build\build\src\media\audioipc\client'&& set CARGO_PKG_VERSION_PATCH=0&& set CARGO_PKG_NAME=audioipc-client&& set CARGO='\\?\Z:\task_1571701454\fetches\rustc\bin\cargo.exe'&& set PATH='z:/build/build/src/obj-firefox\debug\deps;Z:\task_1571701454\fetches\rustc\bin;z:\build\fetches\clang\bin;z:\build\fetches\clang\bin;c:\Program Files\Mercurial;c:\mozilla-build\bin;c:\mozilla-build\kdiff3;c:\mozilla-build\moztools-x64\bin;c:\mozilla-build\mozmake;C:\mozilla-build\msys\bin;C:\mozilla-build\msys\local\bin;c:\mozilla-build\nsis-3.01;c:\mozilla-build\python;c:\mozilla-build\python\Scripts;c:\mozilla-build\python3;c:\Windows\system32;c:\Windows;c:\Windows\System32\Wbem;c:\Windows\System32\WindowsPowerShell\v1.0\;c:\Program Files\Amazon\cfn-bootstrap\;c:\Program Files (x86)\GNU\GnuPG\pub;c:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\;c:\mozilla-build\python\lib\site-packages\pywin32_system32;c:\mozilla-build\python\lib\site-packages\pywin32_system32;c:\mozilla-build\python\lib\site-packages\pywin32_system32;z:/build/build/src/vs2017_15.8.4/VC/bin/HostX64/x86;C:\Users\task_1571701454\.cargo\bin;z:\build\.mozbuild\clang\bin;z:\build\.mozbuild\cbindgen;z:\build\.mozbuild\nasm;z:/build/build/src/vs2017_15.8.4/VC/bin/HostX64/x64'&& set CARGO_PKG_VERSION_MAJOR=0&& set CARGO_PKG_AUTHORS='Matthew Gregan <[e-mail]>:Dan Glastonbury <[e-mail]>'&& set CARGO_PKG_HOMEPAGE=&& set CARGO_PKG_VERSION_MINOR=4&& set CARGO_PKG_VERSION_PRE=&& set CARGO_PKG_VERSION=0.4.0&& set CARGO_PKG_DESCRIPTION='Cubeb Backend for talking to remote cubeb server.'&& set CARGO_PKG_REPOSITORY=&& z:/build/fetches/sccache/sccache.exe 'z:/build/fetches/rustc/bin/rustc.exe' --edition=2018 --crate-name audioipc_client 'media\audioipc\client\src\lib.rs' --error-format=json --json=diagnostic-rendered-ansi,artifacts --crate-type lib --emit=dep-info,metadata,link -C opt-level=1 -C panic=abort -C debuginfo=2 -C debug-assertions=on -C metadata=47d050ac61e1cb66 -C extra-filename=-47d050ac61e1cb66 --out-dir 'z:/build/build/src/obj-firefox\i686-pc-windows-msvc\debug\deps' --target i686-pc-windows-msvc -C 'linker=z:/build/build/src/build/cargo-linker.bat' -L 'dependency=z:/build/build/src/obj-firefox\i686-pc-windows-msvc\debug\deps' -L 'dependency=z:/build/build/src/obj-firefox\debug\deps' --extern 'audio_thread_priority=z:/build/build/src/obj-firefox\i686-pc-windows-msvc\debug\deps\libaudio_thread_priority-a925d34325a91607.rlib' --extern 'audioipc=z:/build/build/src/obj-firefox\i686-pc-windows-msvc\debug\deps\libaudioipc-897de4c761b937ce.rmeta' --extern 'cubeb_backend=z:/build/build/src/obj-firefox\i686-pc-windows-msvc\debug\deps\libcubeb_backend-d3d9ea424532d2a5.rmeta' --extern 'futures=z:/build/build/src/obj-firefox\i686-pc-windows-msvc\debug\deps\libfutures-3fe77abd3e748f84.rmeta' --extern 'futures_cpupool=z:/build/build/src/obj-firefox\i686-pc-windows-msvc\debug\deps\libfutures_cpupool-fcd3c1969431f79f.rmeta' --extern 'log=z:/build/build/src/obj-firefox\i686-pc-windows-msvc\debug\deps\liblog-617440844bec24bf.rmeta' --extern 'tokio=z:/build/build/src/obj-firefox\i686-pc-windows-msvc\debug\deps\libtokio-9123921715bbd77c.rmeta' -C opt-level=2 -C debuginfo=2 -C force-frame-pointers=yes -Dwarnings (exit code: 1)
[task 2019-10-22T00:28:05.971Z] 00:28:05 INFO - warning: build failed, waiting for other jobs to finish...
[task 2019-10-22T00:28:05.971Z] 00:28:05 INFO - error: build failed
[task 2019-10-22T00:28:05.971Z] 00:28:05 INFO - z:/build/build/src/config/makefiles/rust.mk:259: recipe for target 'force-cargo-library-build' failed

Comment 5

[Matthew Gregan [:kinetik]]

Attachment: Bug 1590246 - Update audioipc to 8af8083a. r?chunmin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae889c20904d
Update audioipc to 8af8083a.  r=chunmin
https://hg.mozilla.org/integration/autoland/rev/911309b064df
Vendor Rust.  r=chunmin

Comment 7

[Matthew Gregan [:kinetik]]

Relanded with simple fix.

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ae889c20904d
https://hg.mozilla.org/mozilla-central/rev/911309b064df