1590249 - Enable AudioIPC on Windows in Nightly only

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, task, P2)

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Bug 1590249 - Enable AudioIPC on Windows in Nightly builds. r?chunmin

Depends on D50001

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Bug 1590249 - Fix media/audioipc/update.sh when run on Windows. r?chunmin

Depends on D50004

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a132b59ed504
Enable AudioIPC on Windows in Nightly builds.  r=chunmin
https://hg.mozilla.org/integration/autoland/rev/fee677cef072
Fix media/audioipc/update.sh when run on Windows.  r=chunmin

Comment 4

[Arthur Iakab [arthur_iakab]]

Backed out 2 changesets (bug 1590249) for causing a spike in webgl crashes. CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/347ae69f8681d8b2344834122b583bc5850bfcdb

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=273361444&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunning%2Cpending%2Crunnable&searchStr=webgl&revision=fee677cef07295ce781b6d5a11221aefb474fb97

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=273361444&repo=autoland

Failures https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunning%2Cpending%2Crunnable&searchStr=webgl&fromchange=c649a8137896898d83b26df0c2e66c2ef7b0f405

Matthew can you please take a look?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:kinetik, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Matthew Gregan [:kinetik]]

Still working on this. I have a fix for the test failures, patch up for review soon.

Comment 7

[Matthew Gregan [:kinetik]]

The failure in "Windows debug mochitest-webgl1-ext-e10s" is fixed. That revealed a failure in "Windows debug mochitest-browser-chrome-e10s-5", which has resisted my attempts at debugging so far. I'll disable AudioIPC for that test, land this bug, then continue attempting to fix that test in bug 1610640.

Comment 8

[Matthew Gregan [:kinetik]]

Attachment: Bug 1590249 - Fix media/audioipc/update.sh when run on Windows. r?chunmin

Comment 9

[Matthew Gregan [:kinetik]]

Attachment: Bug 1590249 - Update audioipc to 86d49ddf. r?chunmin

Depends on D60614

Comment 10

[Matthew Gregan [:kinetik]]

Attachment: Bug 1590249 - Vendor Rust. r?chunmin

Depends on D60615

Comment 11

[Matthew Gregan [:kinetik]]

Attachment: Bug 1590249 - Remove AudioIPC stack/pool size prefs from all.js. r?chunmin

These are intended to be hidden prefs, so shouldn't show up in about:config.
Also sync current pref defaults with CubebUtils.cpp, which was out of date.

Depends on D60616

Comment 12

[Matthew Gregan [:kinetik]]

Attachment: Bug 1590249 - Enable AudioIPC on Windows in Nightly builds. r?chunmin

Depends on D60617

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36f6505b50c9
Fix media/audioipc/update.sh when run on Windows. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/0a7873a6b522
Update audioipc to 86d49ddf.  r=chunmin
https://hg.mozilla.org/integration/autoland/rev/ed1cd65eedae
Vendor Rust.  r=chunmin
https://hg.mozilla.org/integration/autoland/rev/c675b890508d
Remove AudioIPC stack/pool size prefs from all.js.  r=chunmin

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/301b1a49db9b
Enable AudioIPC on Windows in Nightly builds. r=chunmin

Comment 15

[Dorel Luca [:dluca]]

Backed out 5 changesets (bug 1590249) for Build bustage in AudioThreadPriorityError. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286490193&repo=autoland&lineNumber=17689

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=c675b890508d27131d8ed2653831cc4dbceac3cf

Backout:
https://hg.mozilla.org/integration/autoland/rev/ecb1125ee6ea1ddcc998e99970a4830356a99817

Comment 16

[Matthew Gregan [:kinetik]]

A dependency updated in audioipc, audio_thread_priority 0.21, fails to build on Android. It looks like this is fixed upstream already, but audio_thread_priority will need a version bump and release for audioipc to pick this up.

For now, I'll land everything but the audio_thread_priority 0.21 update.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6f08a30777b
Fix media/audioipc/update.sh when run on Windows. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/3939f37f4740
Update audioipc to 86d49ddf.  r=chunmin
https://hg.mozilla.org/integration/autoland/rev/0ecf5436ce8b
Vendor Rust.  r=chunmin
https://hg.mozilla.org/integration/autoland/rev/6987ef5d3eec
Remove AudioIPC stack/pool size prefs from all.js.  r=chunmin
https://hg.mozilla.org/integration/autoland/rev/bde8dfc8fea3
Enable AudioIPC on Windows in Nightly builds. r=chunmin

Comment 18

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a6f08a30777b
https://hg.mozilla.org/mozilla-central/rev/3939f37f4740
https://hg.mozilla.org/mozilla-central/rev/0ecf5436ce8b
https://hg.mozilla.org/mozilla-central/rev/6987ef5d3eec
https://hg.mozilla.org/mozilla-central/rev/bde8dfc8fea3