1590317 - [aboutprofiling] Can't change the slider values using the keyboard only

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Description

[Julien Wajsberg [:julienw]]

I realized we can't change the slider values using the keyboard only.
For the interval it's possible to move between 0.8ms and 1ms. I believe this is because of our use of custom scales.

This is where this is implemented https://searchfox.org/mozilla-central/source/devtools/client/performance-new/components/Range.js.
I'm not sure what the best strategy is.
I wonder if we could use the step attribute of the input type=range element instead of rounding manually to 1 digit like we do in onChange. That would be my prefered option, and I'd like some proof that it doesn't work before moving forward with another solution.
If that's not possible we should likely handle keydown as well as onChange.

Note it's not a regression because the addon-based panel has the same problem. But it's still important.

Comment 1

[Julien Wajsberg [:julienw]]

This is still true for the new about:profiling UI.

Comment 2

[Greg Tatum [:gregtatum]]

For what it's worth, it's also the case in the Gecko Profiler Addon.

Comment 3

[James Teh [:Jamie]]

Access-s2 for lack of keyboard support as per https://wiki.mozilla.org/Accessibility/Triage

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1590317 - [devtools] Fix keyboard navigation for about:profiling range inputs

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd616f1cd786
[devtools] Fix keyboard navigation for about:profiling range inputs r=julienw

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/bd616f1cd786