Closed Bug 1590385 Opened 6 years ago Closed 6 years ago

Permafailing TestScriptPreloader.test_preloader_requests_histogram | browser_startupcache_telemetry.js when Gecko version increases to 73 on 2019-12-02

Categories

(Core :: XPConnect, defect, P2)

Product:
Core
Component:
XPConnect
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- unaffected
firefox70 --- unaffected
firefox71 --- unaffected
firefox72 + verified

People

(Reporter: nataliaCs, Assigned: alexical)

References

Details

Attachments

(2 files)

Bug 1590385 - Renew startup cache / script preloader telemetry r?mconley
47 bytes, text/x-phabricator-request
Details | Review
Request for data collection review form
3.03 KB, text/plain
chutten
: data-review+
Details

[Tracking Requested - why for this release]:
Version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=de9c063a11c4dff69eadce48a38205c01441aa3a&searchStr=mn&selectedJob=272366401

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272366401&repo=try&lineNumber=51002

[task 2019-10-22T12:02:59.823Z] 12:02:59 INFO - 1571745779820 Marionette DEBUG 1 <- [1,12,null,{"value":null}]
[task 2019-10-22T12:02:59.844Z] 12:02:59 INFO - 1571745779840 Marionette DEBUG 1 -> [0,13,"WebDriver:GetPageSource",{}]
[task 2019-10-22T12:02:59.854Z] 12:02:59 INFO - 1571745779844 Marionette DEBUG 1 <- [1,13,null,{"value":"<html><head></head><body></body></html>"}]
[task 2019-10-22T12:02:59.868Z] 12:02:59 INFO - TEST-UNEXPECTED-ERROR | js/xpconnect/tests/marionette/test_preloader_telemetry.py TestScriptPreloader.test_preloader_requests_histogram | JavascriptException: TypeError: snapshot.parent.SCRIPT_PRELOADER_REQUESTS is undefined
[task 2019-10-22T12:02:59.868Z] 12:02:59 INFO - stacktrace:
[task 2019-10-22T12:02:59.869Z] 12:02:59 INFO - @tests/js/xpconnect/tests/marionette/test_preloader_telemetry.py:77:17
[task 2019-10-22T12:02:59.870Z] 12:02:59 INFO - @tests/js/xpconnect/tests/marionette/test_preloader_telemetry.py:78:8
[task 2019-10-22T12:02:59.870Z] 12:02:59 INFO - evaluate.sandbox/promise<@chrome://marionette/content/evaluate.js:138:10
[task 2019-10-22T12:02:59.871Z] 12:02:59 INFO - evaluate.sandbox@chrome://marionette/content/evaluate.js:114:17
[task 2019-10-22T12:02:59.872Z] 12:02:59 INFO - GeckoDriver.prototype.execute_@chrome://marionette/content/driver.js:1070:28
[task 2019-10-22T12:02:59.872Z] 12:02:59 INFO - async*GeckoDriver.prototype.executeScript@chrome://marionette/content/driver.js:945:30
[task 2019-10-22T12:02:59.873Z] 12:02:59 INFO - despatch@chrome://marionette/content/server.js:305:40
[task 2019-10-22T12:02:59.873Z] 12:02:59 INFO - execute@chrome://marionette/content/server.js:275:16
[task 2019-10-22T12:02:59.874Z] 12:02:59 INFO - onPacket/<@chrome://marionette/content/server.js:248:20
[task 2019-10-22T12:02:59.874Z] 12:02:59 INFO - onPacket@chrome://marionette/content/server.js:249:9
[task 2019-10-22T12:02:59.875Z] 12:02:59 INFO - _onJSONObjectReady/<@chrome://marionette/content/transport.js:501:20
[task 2019-10-22T12:02:59.875Z] 12:02:59 INFO - Traceback (most recent call last):
[task 2019-10-22T12:02:59.876Z] 12:02:59 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_harness/marionette_test/testcases.py", line 159, in run
[task 2019-10-22T12:02:59.876Z] 12:02:59 INFO - testMethod()
[task 2019-10-22T12:02:59.877Z] 12:02:59 INFO - File "/builds/worker/workspace/build/tests/marionette/tests/js/xpconnect/tests/marionette/test_preloader_telemetry.py", line 22, in test_preloader_requests_histogram
[task 2019-10-22T12:02:59.877Z] 12:02:59 INFO - histogram = self.get_histogram("SCRIPT_PRELOADER_REQUESTS")
[task 2019-10-22T12:02:59.878Z] 12:02:59 INFO - File "/builds/worker/workspace/build/tests/marionette/tests/js/xpconnect/tests/marionette/test_preloader_telemetry.py", line 75, in get_histogram
[task 2019-10-22T12:02:59.878Z] 12:02:59 INFO - """.format(name))
[task 2019-10-22T12:02:59.878Z] 12:02:59 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 1596, in execute_script
[task 2019-10-22T12:02:59.879Z] 12:02:59 INFO - rv = self._send_message("WebDriver:ExecuteScript", body, key="value")
[task 2019-10-22T12:02:59.879Z] 12:02:59 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/decorators.py", line 26, in _
[task 2019-10-22T12:02:59.879Z] 12:02:59 INFO - return func(*args, **kwargs)
[task 2019-10-22T12:02:59.880Z] 12:02:59 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 598, in _send_message
[task 2019-10-22T12:02:59.880Z] 12:02:59 INFO - self._handle_error(err)
[task 2019-10-22T12:02:59.881Z] 12:02:59 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 618, in _handle_error
[task 2019-10-22T12:02:59.881Z] 12:02:59 INFO - raise errors.lookup(error)(message, stacktrace=stacktrace)
[task 2019-10-22T12:02:59.882Z] 12:02:59 INFO - TEST-INFO took 7311ms

entering test: js/xpconnect/tests/marionette/test_preloader_telemetry.py TestScriptPreloader.test_preloader_requests_histogram

Summary: Permafailing preloader_telemetry.py TestScriptPreloader.test_preloader_requests_histogram | JavascriptException: TypeError: snapshot.parent.SCRIPT_PRELOADER_REQUESTS is undefined when Gecko version increases to 73 on 2019-12-02 → Permafailing TestScriptPreloader.test_preloader_requests_histogram | browser_startupcache_telemetry.js when Gecko version increases to 73 on 2019-12-02

These will be expiring - they're still relevant though, given recent
work on the startup cache and continued interest in startup perf.

Depends on D50512

Flags: needinfo?(dothayer)

The priority flag is not set for this bug.
:peterv, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(peterv)
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8fe301759bc7 Renew startup cache / script preloader telemetry r=mconley

Did this expansion of the data collection receive Data Collection Review?

Flags: needinfo?(dothayer)

(In reply to Chris H-C :chutten from comment #5)

Did this expansion of the data collection receive Data Collection Review?

Ack, perhaps I invented a memory that extending the duration of a collection or just adding an alert email address didn't require data collection review. Is this not the case? If so, would you like me to request a data review for the existing push or request it be backed out ASAP?

Flags: needinfo?(dothayer) → needinfo?(chutten)

Extending the duration requires it (adding an alert email doesn't).

We can do it now, no need to back it out.

Flags: needinfo?(chutten)
Attachment #9106994 - Flags: data-review?(chutten)
Comment on attachment 9106994 [details] Request for data collection review form DATA COLLECTION REVIEW RESPONSE: Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? Yes. This collection is Telemetry so is documented in its definitions files [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and [Scalars.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Scalars.yaml) as well as the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/). Is there a control mechanism that allows the user to turn the data collection on and off? Yes. This collection is Telemetry so can be controlled through Firefox's Preferences. If the request is for permanent data collection, is there someone who will monitor the data over time? No. This collection will expire in Firefox 77. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Category 1, Technical. Is the data collection request for default-on or default-off? Default on for all channels. Does the instrumentation include the addition of any new identifiers? No. Is the data collection covered by the existing Firefox privacy notice? Yes. Does there need to be a check-in in the future to determine whether to renew the data? Yes. Doug Thayer is responsible for renewing or removing the collection before it expires in Firefox 77. --- Result: datareview+
Attachment #9106994 - Flags: data-review?(chutten) → data-review+

https://hg.mozilla.org/mozilla-central/rev/8fe301759bc7

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox72: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Assignee: nobody → dothayer
Flags: needinfo?(peterv)
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: