1590445 - After upgrading to Firefox 70, zoom-level-indicator on certain sites like Facebook and Google disappears, when using text-only zoom.

Status: VERIFIED FIXED

(Firefox :: General, defect, P2)

Description

[Abhi]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Opened sites like Facebook or Google after upgrading to Firefox 70 and zoomed up to 130% (text-only zoom).

Actual results:

The zoom-level-indicator disappeared. The zoom-level is wrongly taken to be 100% and hence it is not shown, when actually it is not 100%. In the menu also zoom of 100% shows when actually it should be 130%.

Expected results:

The zoom level indicator should have been visible with '130' showing. In the menu, 130% should be showing as zoom-percentage, not 100%.

Comment 1

[YF (Yang)]

I can't see the problem in Fx70.0 & Fx71.0b3 on Win10 1903.

Comment 2

[Botond Ballo [:botond]]

Can you clarify what you mean by "text-only zoom"?

Can you also mention how you are zooming, e.g. via Ctrl+Plus, Ctrl+mousewheel, View -> Zoom menu item, hamburger menu, etc.?

Do you have any addons installed (particularly addons related to zooming)?

Comment 3

[Abhi]

(In reply to Botond Ballo [:botond] from comment #2)

Can you clarify what you mean by "text-only zoom"?

Can you also mention how you are zooming, e.g. via Ctrl+Plus, Ctrl+mousewheel, View -> Zoom menu item, hamburger menu, etc.?

Do you have any addons installed (particularly addons related to zooming)?

Thanks for responding. By text-only zoom, I mean I have checked the option View>Zoom>Zoom Text Only.

No matter by which option I zoom, the bug remains. For example, I zoom Facebook to 120% and close the tab. Later when I open Facebook again, the text remains zoomed to 120% but the zoom-indicator in the hamburger menu shows 100% and the zoom-indicator in the address bar does not appear because the browser wrongly assumes the zoom to be 100%.

I do have addons installed, none related to zooming, but I opened Firefox in safe-mode (addons disabled) and the bug was still there.

Not all sites are affected by this bug. 80% sites work fine. The bug appears in sites like Facebook, Wikiwand, Google and Koimoi.

This bug is present in Firefox 71 and beyond, also in 71.0b3 and 71.0b4. I went back to firefox 69.0.3 and it worked fine. I again installed Firfox 70 and the bug was there. Comodo IceDragon, that is based on Firefox 65, is also free of this bug.

Comment 4

[nyanpasu64]

I also experienced this bug. In my case, not only do % indicators vanish, but they flicker multiple times, each time causing further zoom operations to assume the current state is 100%.

Steps to reproduce:

• In a just-refreshed test profile, change menu "View/Zoom/Zoom Text Only" to checked.
• Visit https://sarunw.com/posts/dark-color/ (which has many iframes).
• Zoom out to 80% or so
• Refresh the page

Actual results:

• The zoom indicator starts out visible, (disappears and reappears) twice, and disappears forever.
• If I refresh the page with the zoom indicator missing, it (appears and disappears) 3 times.
• If I refresh the page, wait for the flickering to end, and press Ctrl - to zoom out, the page zooms out to 90% (as if the prior zoom state was 100%), regardless of my previous zoom state. (If I press Ctrl +, the page zooms to 110% regardless of prior zoom state.)
• If I refresh and hold Ctrl -, the page jumps to 90% each time the zoom indicator disappears.
• I think I also observed some lag where the page took several seconds to respond to my Ctrl {+,-} commands.

I also get issues on http://asdf.com/ (possibly due to ad iframes).
I do not get issues on http://example.com/ or https://www.iana.org/domains/reserved or https://htmledit.squarefree.com/ (which uses frameset) . (Note that weird things happen if you refresh on htmledit.)

Comment 5

[YF (Yang)]

I can reproduce the problem by comment 4.

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e302a2dfc55b5cd44961ab7e55d549205a3c6d1c&tochange=2bdd2503fbdb0408ceb2c46a07311543a123c950

Comment 6

[Mark Banner (:standard8)]

Neil, could you triage this please, it looks like it was caused by bug 1577388.

Comment 7

[Neil Deakin]

Attachment: Bug 1590445, only adjust zoom level for FullZoomChange and TextZoomChange events for top-level frames, r=mconley

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Likely too late for a fix in 70, but we could still potentially take a patch in 71/72.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfa48920ac65
only adjust zoom level for FullZoomChange and TextZoomChange events for top-level frames, r=mconley

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/bfa48920ac65

Comment 11

[Pascal Chevrel:pascalc]

Hi Neil, do you think that this fix is a good candidate for an uplift to beta? If it is, please request the uplift (3 betas left before RC), thanks!

Comment 12

[Neil Deakin]

Comment on attachment 9106179 [details]
Bug 1590445, only adjust zoom level for FullZoomChange and TextZoomChange events for top-level frames, r=mconley

Beta/Release Uplift Approval Request

• User impact if declined: Zoom level indicator does not appear on the address bar for some top sites
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Steps are in comment 4. Automated tests are to come, but fission-enabled tests blocked by 1592963.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed: None

Comment 13

[Pascal Chevrel:pascalc]

Comment on attachment 9106179 [details]
Bug 1590445, only adjust zoom level for FullZoomChange and TextZoomChange events for top-level frames, r=mconley

Fix for a 71 regression with our zoom level indicator. The patch is minimal and was on nightly a few days with no reported regression, uplift approved for 71 beta 10, thanks.

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1c239d21550f

Comment 15

[Anca Soncutean, Desktop QA]

I’ve reproduced this issue (both the flicker and the zoom level indicator disappearance) with Fx 71.0b9 on Windows 10 x64.
The issue is verified fixed with Fx 71.0b10 and Fx 72.0a1 (2019-11-14) on Windows 10 x64, macOS 10.15 and Ubuntu 18.04 x64.