1590456 - Merge MailContentHandler.jsm and SetDefaultMail.jsm into MessengerContentHandler.jsm

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Comment 1

[Khushil Mistry [:khushil324]]

More details: https://bugzilla.mozilla.org/show_bug.cgi?id=1562313#c2

Comment 2

[Jorg K (CEST = GMT+2)]

Please paste bug numbers as bug 1562313 comment #2 since that gives a tooltip, the fill link doesn't.

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1590456_merge-MailContentHandler-SetDefaultMail-0.patch

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9118020 [details] [diff] [review]
Bug-1590456_merge-MailContentHandler-SetDefaultMail-0.patch

Review of attachment 9118020 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/MessengerContentHandler.jsm
@@ +14,5 @@
>  var URI_INHERITS_SECURITY_CONTEXT =
>    Ci.nsIProtocolHandler.URI_INHERITS_SECURITY_CONTEXT;
>  
> +// defined in nsIContentHandler.idl.
> +var NS_ERROR_WONT_HANDLE_CONTENT = 0x805d0001;

please remove, see below

@@ +295,5 @@
>          null
>        );
>      }
>  
> +    /* nsICommandLineHandler */

please remove this line. It's already there above

@@ +534,5 @@
> +        !Cc["@mozilla.org/webnavigation-info;1"]
> +          .getService(Ci.nsIWebNavigationInfo)
> +          .isTypeSupported(aContentType, null)
> +      ) {
> +        throw NS_ERROR_WONT_HANDLE_CONTENT;

throw Cr.NS_ERROR_WONT_HANDLE_CONTENT;

@@ +537,5 @@
> +      ) {
> +        throw NS_ERROR_WONT_HANDLE_CONTENT;
> +      }
> +    } catch (e) {
> +      throw NS_ERROR_WONT_HANDLE_CONTENT;

throw Cr.NS_ERROR_WONT_HANDLE_CONTENT;

@@ +547,5 @@
> +    // them internally as we know what to do. For http and https we don't
> +    // actually deal with external windows very well, so we redirect them to
> +    // the external browser.
> +    if (!aRequest.URI.schemeIs("http") && !aRequest.URI.schemeIs("https")) {
> +      throw NS_ERROR_WONT_HANDLE_CONTENT;

throw Cr.NS_ERROR_WONT_HANDLE_CONTENT;

Comment 5

[Khushil Mistry [:khushil324]]

Attachment: Bug-1590456_merge-MailContentHandler-SetDefaultMail-1.patch

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=6ac8d62616dc79f902959769c7de41e0e3470bbc

Comment 6

[Jorg K (CEST = GMT+2)]

Hmm, those two bct failures don't look familiar, are you sure you're not causing them?

Comment 7

[Khushil Mistry [:khushil324]]

Attachment: Bug-1590456_merge-MailContentHandler-SetDefaultMail-2.patch

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=654046eab1b1b748b467a1474fc1c2d1c472ba9c

Corrected linting error.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9a43763d30c8
Merge MailContentHandler.jsm and SetDefaultMail.jsm into MessengerContentHandler.jsm. r=mkmelin