Closed Bug 1590456 Opened 9 months ago Closed 6 months ago

Merge MailContentHandler.jsm and SetDefaultMail.jsm into MessengerContentHandler.jsm

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 73.0

People

(Reporter: khushil324, Assigned: khushil324)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Assignee: nobody → khushil324
See Also: → 1562313

Please paste bug numbers as bug 1562313 comment #2 since that gives a tooltip, the fill link doesn't.

Attachment #9118020 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Attachment #9118020 - Attachment is patch: true
Comment on attachment 9118020 [details] [diff] [review]
Bug-1590456_merge-MailContentHandler-SetDefaultMail-0.patch

Review of attachment 9118020 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/MessengerContentHandler.jsm
@@ +14,5 @@
>  var URI_INHERITS_SECURITY_CONTEXT =
>    Ci.nsIProtocolHandler.URI_INHERITS_SECURITY_CONTEXT;
>  
> +// defined in nsIContentHandler.idl.
> +var NS_ERROR_WONT_HANDLE_CONTENT = 0x805d0001;

please remove, see below

@@ +295,5 @@
>          null
>        );
>      }
>  
> +    /* nsICommandLineHandler */

please remove this line. It's already there above

@@ +534,5 @@
> +        !Cc["@mozilla.org/webnavigation-info;1"]
> +          .getService(Ci.nsIWebNavigationInfo)
> +          .isTypeSupported(aContentType, null)
> +      ) {
> +        throw NS_ERROR_WONT_HANDLE_CONTENT;

throw Cr.NS_ERROR_WONT_HANDLE_CONTENT;

@@ +537,5 @@
> +      ) {
> +        throw NS_ERROR_WONT_HANDLE_CONTENT;
> +      }
> +    } catch (e) {
> +      throw NS_ERROR_WONT_HANDLE_CONTENT;

throw Cr.NS_ERROR_WONT_HANDLE_CONTENT;

@@ +547,5 @@
> +    // them internally as we know what to do. For http and https we don't
> +    // actually deal with external windows very well, so we redirect them to
> +    // the external browser.
> +    if (!aRequest.URI.schemeIs("http") && !aRequest.URI.schemeIs("https")) {
> +      throw NS_ERROR_WONT_HANDLE_CONTENT;

throw Cr.NS_ERROR_WONT_HANDLE_CONTENT;
Attachment #9118020 - Flags: review?(mkmelin+mozilla) → review+

Hmm, those two bct failures don't look familiar, are you sure you're not causing them?

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/9a43763d30c8
Merge MailContentHandler.jsm and SetDefaultMail.jsm into MessengerContentHandler.jsm. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 73.0
You need to log in before you can comment on or make changes to this bug.