1590521 - [Fission] rename various Legacy*SH classes to something more descriptive

Status: RESOLVED WONTFIX

(Core :: DOM: Navigation, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

Currently ash has rather hard to understand naming for various class, and at least for me the naming makes it really hard to review the code.

LegacySHEntry is an SHEntry in parent process. Nothing really legacy there.

nsLegacySHEntry is a very different class. It is basically the old nsSHEntry class.

nsSHEntry isn't what nsSHEntry used to be, but it is a base class.

LegacySHistory is an nsISHistory implementation in parent process, something to be used as parent side of the IPC stuff.

nsSHistory is the actual legacy nsISHistory implementation

I'm proposing to change:
LegacySHEntry -> ParentProcessSHEntry
nsLegacySHEntry -> SameProcessSHEntry, or could be SingleProcessSHEntry
nsSHEntry -> SHEntryBase
LegacySHistory -> ParentProcessSHistory
nsSHistory -> SameProcessSHistory, or could be SingleProcessSHEntry

I think I prefer the SingleProcess variants, since they hint about non-IPC-shistory.

Comment 1

[Anny Gakhokidze [:annyG]]

I prefer SingleProcess variants to SameProcessSHistory, to distinguish non-IPC-shistory case from concepts of same process-ness in Fission.

Comment 2

[Peter Van der Beken [:peterv]]

I still don't think we should care about it at this point in the project. If you insist on going through with it you need to approach it in light of the redesign, so that we don't have to rename everything again once we removed all the obsolete classes (which I personally think is everything except nsSHistory and nsSHEntry).

Comment 3

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 4

[Chris Peterson [:cpeterson]]

Peter says some session patches are in flight and we don't want to bit rot those patches by renaming these Legacy*SH classes yet.

Tracking for Fission Nightly (M6)

Comment 5

[Peter Van der Beken [:peterv]]

These classes are gone.