Open Bug 1546759 Opened 1 year ago Updated 2 months ago

Change nsSHistory::WalkHistoryEntries to walk browsing context tree instead of doc shell tree

Categories

(Core :: DOM: Navigation, enhancement, P2)

enhancement

Tracking

()

Fission Milestone M5

People

(Reporter: annyG, Assigned: annyG)

References

(Blocks 3 open bugs)

Details

Attachments

(11 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

To accomodate recent session history changes, we need to change nsSHistory::WalkHistoryEntries to walk browsing context tree instead of doc shell tree

Blocks: 1546762
Fission Milestone: --- → M3
Priority: -- → P3
Fission Milestone: M3 → M4
Blocks: 1579093
No longer blocks: 1579093
Attachment #9087263 - Attachment description: Bug 1546759 - Part 2: Add mOSHE and mLSHE to BrowsingContext and update them appropriately → Bug 1546759 - Part 2: Add mOSHE and mLSHE to BrowsingContext and update them appropriately,
Attachment #9087264 - Attachment description: Bug 1546759 - Part 3: Add an IPC call from parent to child to swap history entries in docshell → Bug 1546759 - Part 3: Add an IPC call from parent to child in PContent.ipdl to swap history entries in docshell,
Attachment #9087265 - Attachment description: Bug 1546759 - Part 4: Add a method for swapping history entries to Browsing Context → Bug 1546759 - Part 4: Add a method for swapping history entries to Browsing Context,
Attachment #9087266 - Attachment description: Bug 1546759 - Part 5: Move SetChildHistoryEntry to parent process → Bug 1546759 - Part 5: Move SetChildHistoryEntry to parent process,
Attachment #9087267 - Attachment description: Bug 1546759 - Part 6: Move CloneAndReplaceChild to parent process → Bug 1546759 - Part 6: Move CloneAndReplaceChild to parent process,
Attachment #9087268 - Attachment description: Bug 1546759 - Part 7.1 update nsDocShell::SetHistoryEntry to call ::Top() → Bug 1546759 - Part 7.1 Update nsDocShell::SetHistoryEntry to call ::Top(),
Attachment #9087269 - Attachment description: Bug 1546759 - Part 7.2 Consolidate calls inside of nsDocShell::SetHistoryEntry → Bug 1546759 - Part 7.2 Consolidate calls inside of nsDocShell::SetHistoryEntry,
Depends on: 1555964
Fission Milestone: M4 → M5
Priority: P3 → P2
Attachment #9087270 - Attachment description: Bug 1546759 - Part 8: Consolidate several IPC calls such that CloneAndReplace is called from parent again → Bug 1546759 - Part 8: Consolidate several IPC calls such that CloneAndReplace is called from parent again,
Depends on: 1581970
Depends on: 1583321
No longer depends on: 1581970
See Also: → 1581970
No longer depends on: 1555964
Attachment #9087271 - Attachment description: Bug 1546759 - Part 9: Make SetChildHistoryEntry and CloneAndReplaceChild fission compatible → Bug 1546759 - Part 9: Make SetChildHistoryEntry and CloneAndReplaceChild fission compatible,
Blocks: 1590521

TODO currently coming up with a great and extended commit message

You need to log in before you can comment on or make changes to this bug.