1590522 - login-item breach banner overlaps the Lockwise meatball (…) menu

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Matthew N. [:MattN]]

Attachment: Screen Shot 2019-10-22 at 3.07.18 PM.png

If a breach warning is showing, it can overlap the about:logins page menu.

Since bug 1583795 isn't in Fx70, the impact of this is lower than in Fx71 since non-breach logins will be selected by default

Comment 1

[Matthew N. [:MattN]]

Mass removing [skyline] and [passwords:management] from about:logins bugs which are no longer useful.

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1590522 - Render the about:logins menu above .breach-alert. r=sfoster

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc4b38853a11
Render the about:logins menu above .breach-alert. r=sfoster

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/cc4b38853a11

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Matt do you think this should be uplifted to beta?

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the latest Nightly 72.0a1 (Build ID: 20191103213857) on Windows 10 x64, Mac 10.14, Ubuntu 16.04 x64.

• The Breach dialog doesn’t overlap the Ellipsis menu anymore.

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 9105444 [details]
Bug 1590522 - Render the about:logins menu above .breach-alert. r=sfoster

(In reply to Pascal Chevrel:pascalc from comment #5)

Matt do you think this should be uplifted to beta?

Yes, I was waiting on verification.

Beta/Release Uplift Approval Request

• User impact if declined: The about:logins menu will overlap breach warnings (breached logins are selected by default) on narrow viewports
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial z-index: 1 addition in CSS
• String changes made/needed: None

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9105444 [details]
Bug 1590522 - Render the about:logins menu above .breach-alert. r=sfoster

Low risk fix for a P1 bug in about:logins, uplift approved for 71 beta 8, thanks.

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4df8cecbb0f5

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue on the Firefox Beta 71.0b8 (Build ID: 20191107101713) on Windows 10 x64, Mac 10.14, Ubuntu 16.04 x64.

• The Breach dialog doesn’t overlap the Ellipsis menu anymore.