1590594 - Adding a breakpoint does not affect skipPausing

Status: VERIFIED FIXED

(DevTools :: Debugger, defect, P1)

Description

[Jason Laster [:jlast]]

What were you doing?

1. enable skip pausing
2. add a breakpoint
3. evaluate something that should hit the breakpoint

ER: breakpoint is hit
AR: breakpoint is skipped, even though the skip breakpoint UI changed

Comment 1

[Jason Laster [:jlast]]

here's a quick video with some of my findigns
https://www.loom.com/share/6229564522c14a6fb73cf82bb0c00386

and some code cleanup that might be nice as well
https://gist.github.com/eb390f6e14065c7a0ffbfeaa4742d425

Comment 2

[David Walsh :davidwalsh]

Attachment: Bug 1590594 - Properly reflect skipping state within the debugger server r=jlast

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/954e66020e31
Properly reflect skipping state within the debugger server r=jlast

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/954e66020e31

Comment 5

[David Walsh :davidwalsh]

Comment on attachment 9103667 [details]
Bug 1590594 - Properly reflect skipping state within the debugger server r=jlast

Beta/Release Uplift Approval Request

• User impact if declined: The "skip pausing" button may continue to be out of sync with the client, thus confusing users why a breakpoint isn't being hit.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Debugger is only audience and wont break the tool.
• String changes made/needed:

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9103667 [details]
Bug 1590594 - Properly reflect skipping state within the debugger server r=jlast

Low risk patch with tests for a visible bug in the debugger, uplift approved for 71 beta 6, thanks.

Comment 7

[Rares Doghi, Desktop QA]

This issue is Verified as Fixed in our latest Nightly build 72.0a1 (2019-10-30) on Windows 10, Mac osX 10.13 and Ubuntu 18.04.

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/44855aed8813

Comment 9

[Peter Magyari (Desktop QA)]

Reproduced the issue on Windows 10, MacOS 10.14 and Ubuntu 18.04 using Firefox Beta 70.0b5 (20191028110005).
Also verified it using Firefox Beta 70.0b6 (20191031113544) and it has been fixed.