Closed Bug 1590635 Opened 6 years ago Closed 1 month ago

LSNG: Add telemetry probes for tracking various performance characteristics

Categories

(Core :: Storage: localStorage & sessionStorage, task, P2)

task

Tracking

()

RESOLVED FIXED

People

(Reporter: janv, Assigned: hsingh)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

We need to better understand how our new implementation behaves in the wild. There are some ideas mentioned in bug 1286798 comment 8, but we might need to add more. This is also needed to prevent performance regressions.

Severity: normal → S3
Blocks: 1906921
Assignee: nobody → hsingh
Assignee: hsingh → nobody
Keywords: leave-open
Assignee: nobody → hsingh
Attachment #9416890 - Attachment description: Bug 1590635: Adding a telemetry to report LS request cancellation.r=janv → Bug 1590635: Adding a telemetry to report LS request cancellation.r=janv,#dom-storage-reviewers

It seems there's currently no good way to report larger debugging information in telemetry except setting a crash annotation and calling MOZ_CRASH or creating a custom ping. A custom ping managed by quota manager looks like a nice, robust and safe way to report debugging information. It would be good to explore that option.

Attachment #9416890 - Attachment description: Bug 1590635: Adding a telemetry to report LS request cancellation.r=janv,#dom-storage-reviewers → Bug 1590635: Adding a telemetry to report LS first-prepare and any LS request cancellation.r=janv,#dom-storage-reviewers
Attachment #9416890 - Attachment description: Bug 1590635: Adding a telemetry to report LS first-prepare and any LS request cancellation.r=janv,#dom-storage-reviewers → Bug 1590635: Adding a telemetry to report LS first-prepare latency. r=janv,#dom-storage-reviewers
Attachment #9416890 - Attachment description: Bug 1590635: Adding a telemetry to report LS first-prepare latency. r=janv,#dom-storage-reviewers → WIP: Bug 1590635: Adding a telemetry to report LS first-prepare latency. r=janv,#dom-storage-reviewers
Attachment #9419308 - Attachment description: Bug 1590635: Adding a telemetry to report LS request cancellation. r=janv,#dom-storage-reviewers → WIP: Bug 1590635: Adding a telemetry to report LS request cancellation. r=janv,#dom-storage-reviewers
Attachment #9416890 - Attachment description: WIP: Bug 1590635: Adding a telemetry to report LS first-prepare latency. r=janv,#dom-storage-reviewers → Bug 1590635: Adding a telemetry to report LS first-prepare latency. r=janv,#dom-storage-reviewers
Attachment #9419308 - Attachment description: WIP: Bug 1590635: Adding a telemetry to report LS request cancellation. r=janv,#dom-storage-reviewers → Bug 1590635: Adding a telemetry to report LS request cancellation. r=janv,#dom-storage-reviewers
Attachment #9416890 - Attachment description: Bug 1590635: Adding a telemetry to report LS first-prepare latency. r=janv,#dom-storage-reviewers → Bug 1590635: Adding a telemetry to report LS perparedatastoreop processing and latency. r=janv,#dom-storage-reviewers
Attachment #9416890 - Attachment description: Bug 1590635: Adding a telemetry to report LS perparedatastoreop processing and latency. r=janv,#dom-storage-reviewers → Bug 1590635: Adding a telemetry to report LS database and perparedatastore processing time. r=janv,#dom-storage-reviewers
Pushed by hsingh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d3eeb7fe9d6 Adding a telemetry to report LS database and perparedatastore processing time. r=janv,dom-storage-reviewers https://hg.mozilla.org/integration/autoland/rev/bebc2a827b41 Adding a telemetry to report LS request cancellation. r=janv,dom-storage-reviewers
See Also: → 1928268
See Also: → 1928270
See Also: → 1928271
See Also: → 1946286
See Also: → 1946288
See Also: → 1946290
See Also: → 1963754
See Also: → 1965142

The leave-open keyword is there and there is no activity for 6 months.
:hsingh, maybe it's time to close this bug?
For more information, please visit BugBot documentation.

Flags: needinfo?(hsingh)

I have already added few new LS metrics as part of this ticket. And I don't have anymore to add at this point.
I think it's make sense to close this task and later create new one on the need-basis.

Flags: needinfo?(hsingh)
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: