1590828 - nsIRemoteAgent should return NS exceptions

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P1)

Description

[Andreas Tolfsen ❲:ato❳]

The new nsIRemoteAgent interface introduced with bug 1543115 did
not change the exceptions thrown internally by the class. To ensure
better interaction with consumers over XPIDL we should ensure the
JS implementation throws NS exceptions.

Comment 1

[Andreas Tolfsen ❲:ato❳]

We first need to fix it so that XPCOM exceptions can be picked up by XPIDL consumers.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1590828: remote: return NS exceptions from nsIRemoteAgent

The nsIRemoteAgent interface introduced with bug 1543115 did
not change the exceptions thrown internally by the class. To ensure
better interaction with consumers over XPIDL we should ensure the
JS implementation throws NS exceptions.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1590828: remote: take appropriate action on errors during startup

Now that nsIRemoteAgent propagates errors correctly to Rust we can
report errors back to the user when something terrible happens.

The effect of all this is that the startup handler can stop Firefox
when the remote agent fails to listen.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7daba7f077e
remote: return NS exceptions from nsIRemoteAgent r=remote-protocol-reviewers,whimboo,maja_zf
https://hg.mozilla.org/integration/autoland/rev/eca7999b3814
remote: take appropriate action on errors during startup r=remote-protocol-reviewers,maja_zf,whimboo

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d7daba7f077e
https://hg.mozilla.org/mozilla-central/rev/eca7999b3814